Skip to content

fix: #35379 , made it is so an error message would be displayed when user sets custom status as an empty string #35380

Open
hiteshm0 wants to merge 2 commits into
RocketChat:developfrom
hiteshm0:new_branch
Open

fix: #35379 , made it is so an error message would be displayed when user sets custom status as an empty string #35380
hiteshm0 wants to merge 2 commits into
RocketChat:developfrom
hiteshm0:new_branch

Conversation

@hiteshm0
Copy link
Copy Markdown

@hiteshm0 hiteshm0 commented Mar 1, 2025

fixing bug where , when the custom status was changed to an empty string it would display a success toast message but wouldn't reflect ( ie the custom status would remain same as before )

fix: and i18n:

Proposed changes (including videos or screenshots)

Issue(s)

#35379

Steps to test or reproduce

Issue shows the steps to reproduce the bug

Further comments

@hiteshm0 hiteshm0 requested a review from a team as a code owner March 1, 2025 14:22
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Mar 1, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 1, 2025

⚠️ No Changeset found

Latest commit: 7619d52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hiteshm0 hiteshm0 changed the title fix: #35379 , made it is so an error message would be displayed when user sets custom message as an empty string fix: #35379 , made it is so an error message would be displayed when user sets custom status as an empty string Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant