Skip to content

fix: Loading Stays Active When Clicking Outside Iframe Popup.#35527

Open
Ansh-dS wants to merge 1 commit into
RocketChat:developfrom
Ansh-dS:loadingIfClcikOutside
Open

fix: Loading Stays Active When Clicking Outside Iframe Popup.#35527
Ansh-dS wants to merge 1 commit into
RocketChat:developfrom
Ansh-dS:loadingIfClcikOutside

Conversation

@Ansh-dS
Copy link
Copy Markdown
Contributor

@Ansh-dS Ansh-dS commented Mar 17, 2025

##Proposed Changes:
This time when you click outside the pop up of "iframe" you shouldn't see loading over "install" button.

Issue(s)

#35518

Steps to Reproduce

  1. Click on the three dots in the left pane.
  2. Select "Marketplace".
  3. Choose an app that:
    • Has not been installed OR
    • Has not been granted permission yet.
  4. A popup with an iframe appears.
  5. Click anywhere outside the iframe/popup.
  6. Observe the loading indicator over the "Install" button

@Ansh-dS Ansh-dS requested a review from a team as a code owner March 17, 2025 12:14
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Mar 17, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 0c0ce74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ansh-dS seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants