-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: Prevent useEmojiOne operations from running every render
#35587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35587 +/- ##
========================================
Coverage 59.73% 59.73%
========================================
Files 2830 2830
Lines 68270 68270
Branches 15134 15134
========================================
Hits 40778 40778
Misses 24881 24881
Partials 2611 2611
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
useEmojiOne operations from running every render
Proposed changes (including videos or screenshots)
Not a great issue, these operations take about 5ms to run. Unfortunately it's happening every navigation/render of the AppLayout component, so it adds up.
Issue(s)
CORE-1042
Steps to test or reproduce
Further comments