fix: provide better identification for 2FA TOTP field #35608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: f1d0664 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…isibility in main channel
Vrohs
changed the title
Vrohs
changed the title
Vrohs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the TOTP field recognition, enhance PR title checks, and add a new type definition. The most important changes include adding the
autocompleteattribute to TOTP input fields, updating the PR title checker configuration, and adding a newSubscribabletype definition.Improvements to TOTP field recognition:
apps/meteor/client/components/TwoFactorModal/TwoFactorTotpModal.tsx: Addedautocomplete="one-time-code"attribute to the TOTP input field to improve recognition by password managers.apps/meteor/client/views/account/security/TwoFactorTOTP.tsx: Addedautocomplete="one-time-code"attribute to the TOTP input field to improve recognition by password managers.Description
This PR addresses an issue where TOTP (Time-based One-Time Password) input fields in Rocket.Chat weren't being properly recognized by password managers like KeePassXC, preventing auto-fill functionality for 2FA codes.
Changes
autoComplete="one-time-code"attribute to TOTP input fieldsTechnical Details
Modified TextInput components in both the TwoFactorTotpModal and TwoFactorTOTP components to include the proper autoComplete attribute, which renders as
autocomplete="one-time-code"in HTML. This is the standard attribute for password managers to identify TOTP fields.Impact
This change improves user experience for anyone using password managers with TOTP capabilities, making the login process more seamless and secure.
Note to maintainers: I've added a changeset file for this improvement. Please help add the "stat: QA assured" label and assign to an appropriate milestone. Thank you!