Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 28, 2025

https://rocketchat.atlassian.net/browse/ARCH-1531

https://rocketchat.atlassian.net/browse/FLAKY-684

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team as a code owner March 28, 2025 20:36
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 28, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: e96f587

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.6.0 milestone Mar 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35648/

Built to branch gh-pages at 2025-03-29 03:08 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (5e3ab1a) to head (e96f587).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35648      +/-   ##
===========================================
- Coverage    59.72%   59.72%   -0.01%     
===========================================
  Files         2829     2829              
  Lines        68233    68230       -3     
  Branches     15125    15124       -1     
===========================================
- Hits         40751    40748       -3     
  Misses       24874    24874              
  Partials      2608     2608              
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the tests/SAML-flaky branch from 1797d91 to dab0ecb Compare March 28, 2025 22:17
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Mar 31, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 31, 2025
@ggazzo ggazzo merged commit c21a7a6 into develop Mar 31, 2025
49 checks passed
@ggazzo ggazzo deleted the tests/SAML-flaky branch March 31, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants