refactor: remove startup from Meteor#35915
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
| return; | ||
| } | ||
|
|
||
| const getUser = async () => { |
There was a problem hiding this comment.
const getUser = async () => {
try {
const utcOffset = moment().utcOffset() / 60;
const user = await synchronizeUserData(uid);
if (!user) {
console.error('User data synchronization failed.'); // Or handle more gracefully
return;
}
if (user.utcOffset !== utcOffset) {
await sdk.call('userSetUtcOffset', utcOffset);
}
if (getUserPreference(user, 'enableAutoAway')) {
const idleTimeLimit = (getUserPreference(user, 'idleTimeLimit') as number | null | undefined) || 300;
UserPresence.awayTime = idleTimeLimit * 1000;
} else {
delete UserPresence.awayTime;
UserPresence.stopTimer();
}
setStatus(user.status);
UserPresence.start();
} catch (error) {
console.error('Error during user startup sequence:', error);
// Potentially set an error state or notify the user
}
};The useStartup hook lacks proper documentation, making it difficult to understand its purpose and usage.
This issue appears in multiple locations:
- apps/meteor/client/hooks/useStartup.ts: Lines 32-52
- apps/meteor/client/hooks/useStartup.ts: Lines 14-14
- apps/meteor/client/views/root/AppLayout.tsx: Lines 27-27
Please add JSDoc comments to theuseStartuphook to clearly explain its functionality and any side effects.
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
| import { synchronizeUserData, removeLocalUserData } from '../lib/userData'; | ||
| import { fireGlobalEvent } from '../lib/utils/fireGlobalEvent'; | ||
|
|
||
| export const useStartup = () => { |
There was a problem hiding this comment.
/**
* @description Hook to handle user-specific initialization after login.
* Synchronizes user data, sets UTC offset, configures presence (auto-away),
* updates status, starts presence tracking, and fires 'startup' and 'status-changed' global events.
*/
export const useStartup = () => {The useStartup hook lacks proper documentation, making it difficult to understand its purpose and usage.
This issue appears in multiple locations:
- apps/meteor/client/hooks/useStartup.ts: Lines 14-14
Please add JSDoc comments to theuseStartuphook to clearly explain its functionality and any side effects.
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #35915 +/- ##
===========================================
- Coverage 61.16% 61.15% -0.01%
===========================================
Files 3014 3014
Lines 71625 71560 -65
Branches 16403 16390 -13
===========================================
- Hits 43808 43762 -46
+ Misses 24850 24830 -20
- Partials 2967 2968 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
1 participant
ARCH-1551
Proposed changes (including videos or screenshots)
WIP
Issue(s)
Steps to test or reproduce
Further comments
This pull request refactors the Rocket.Chat codebase by removing the startup logic from Meteor and introducing a new React hook named
useStartup. TheuseStartuphook is responsible for handling user-specific initialization tasks after login, such as synchronizing user data, setting the UTC offset, configuring user presence based on preferences (including auto-away settings), and managing initial status updates through global events. Additionally, theuseStartuphook has been integrated into theAppLayoutcomponent. The changes are made in theapps/meteor/client/hooks/useStartup.tsandapps/meteor/client/views/root/AppLayout.tsxfiles. The source branch for this refactor isrefactor/startup, and the target branch isdevelop.