-
Notifications
You must be signed in to change notification settings - Fork 12.8k
refactor: remove unread from Meteor
#36001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36001 +/- ##
===========================================
+ Coverage 64.70% 64.72% +0.02%
===========================================
Files 3247 3248 +1
Lines 95434 95463 +29
Branches 17902 17912 +10
===========================================
+ Hits 61753 61791 +38
+ Misses 30778 30770 -8
+ Partials 2903 2902 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
gabriellsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

ARCH-1606
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Open 2 sessions and test notifications:
The unread count should be reflected on favicon
Further comments
This pull request refactors the Rocket.Chat codebase by removing the
unreadfunctionality from Meteor and introducing a new custom React hook nameduseUnread. TheuseUnreadhook is responsible for calculating the total unread count from user subscriptions, updating a session variable, and managing the browser's favicon based on user preferences for unread alerts. It also triggers global events when there are changes to the unread status. Additionally, theuseUnreadhook has been integrated into theLoggedInAreacomponent within theMainLayout.