Skip to content

chore: deprecate getUserRoles saveCustomFields setReaction setUsername saveUserProfile setUserPassword methods#36146

Merged
ggazzo merged 13 commits intodevelopfrom
chore/use-method
Aug 4, 2025
Merged

chore: deprecate getUserRoles saveCustomFields setReaction setUsername saveUserProfile setUserPassword methods#36146
ggazzo merged 13 commits intodevelopfrom
chore/use-method

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 4, 2025 •
edited
Loading

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 4, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fc4b2d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.8.0 milestone Jun 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36146/

Built to branch gh-pages at 2025-08-04 17:31 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.68%. Comparing base (1142862) to head (fc4b2d2).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36146      +/-   ##
===========================================
- Coverage    65.69%   65.68%   -0.02%     
===========================================
  Files         3195     3197       +2     
  Lines       106739   106799      +60     
  Branches     20321    20331      +10     
===========================================
+ Hits         70122    70149      +27     
- Misses       33979    34010      +31     
- Partials      2638     2640       +2
Flag Coverage Δ
e2e 56.98% <85.71%> (+0.04%) ⬆️
unit 71.24% <66.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the chore/use-method branch 5 times, most recently from ee0cff0 to aa91d53 Compare June 6, 2025 18:58
@ggazzo ggazzo modified the milestones: 7.8.0, 7.9.0 Jun 21, 2025
@ggazzo ggazzo force-pushed the chore/use-method branch 4 times, most recently from 8e702a0 to 8206007 Compare July 8, 2025 23:14
@ggazzo ggazzo mentioned this pull request Jul 9, 2025
Merged
@ggazzo ggazzo force-pushed the chore/use-method branch 2 times, most recently from c8293a1 to 3c39d72 Compare July 9, 2025 16:18
@ggazzo ggazzo mentioned this pull request Jul 9, 2025
Merged
@ggazzo ggazzo force-pushed the chore/use-method branch 10 times, most recently from 4d1012d to 7ed3c8f Compare July 10, 2025 17:45
@ggazzo ggazzo requested a review from a team as a code owner August 1, 2025 17:14
sampaiodiego
sampaiodiego requested changes Aug 1, 2025
View reviewed changes
sampaiodiego
sampaiodiego previously approved these changes Aug 1, 2025
View reviewed changes
@ggazzo ggazzo force-pushed the chore/use-method branch from a1ed87f to a605c1d Compare August 1, 2025 19:50
@ggazzo ggazzo force-pushed the chore/use-method branch 2 times, most recently from 0cd1d91 to ae57a64 Compare August 1, 2025 22:54
@ggazzo ggazzo force-pushed the chore/use-method branch 2 times, most recently from b2e4151 to a8e38f3 Compare August 1, 2025 23:24
@ggazzo ggazzo force-pushed the chore/use-method branch from a8e38f3 to 4b512e4 Compare August 1, 2025 23:34
sampaiodiego
sampaiodiego requested changes Aug 4, 2025
View reviewed changes
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 4, 2025
@ggazzo ggazzo merged commit 91348ff into develop Aug 4, 2025
90 of 92 checks passed
@ggazzo ggazzo deleted the chore/use-method branch August 4, 2025 19:35
@OtavioStasiak OtavioStasiak mentioned this pull request Sep 19, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan tassoevan left review comments

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc requested changes

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ggazzo @tassoevan @sampaiodiego @pierre-lehnen-rc