Skip to content

feat: Responsive navigation filters#36227

Merged
dougfabris merged 5 commits into
feat/sidebar-filtersfrom
feat/navigation-filters-responsive
Jun 18, 2025
Merged

feat: Responsive navigation filters#36227
dougfabris merged 5 commits into
feat/sidebar-filtersfrom
feat/navigation-filters-responsive

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Jun 16, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-21
SIDE2-90

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jun 16, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 16, 2025

⚠️ No Changeset found

Latest commit: 167bf7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 16, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36227/

Built to branch gh-pages at 2025-06-17 21:47 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 25.58140% with 32 lines in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (c6c28ed) to head (167bf7e).
Report is 1 commits behind head on feat/sidebar-filters.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/sidebar-filters   #36227      +/-   ##
========================================================
- Coverage                 63.84%   63.82%   -0.03%     
========================================================
  Files                      3134     3136       +2     
  Lines                     98577    98612      +35     
  Branches                  18698    18707       +9     
========================================================
- Hits                      62941    62939       -2     
- Misses                    32918    32949      +31     
- Partials                   2718     2724       +6     
Flag Coverage Δ
e2e 55.18% <25.58%> (-0.02%) ⬇️
unit 69.91% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread apps/meteor/client/views/root/MainLayout/LayoutWithSidebarV2.tsx Outdated
Comment thread apps/meteor/client/views/navigation/contexts/RoomsNavigationContext.ts Outdated
@dougfabris dougfabris marked this pull request as ready for review June 17, 2025 22:02
@dougfabris dougfabris requested a review from a team as a code owner June 17, 2025 22:02
@dougfabris dougfabris merged commit 468a1d2 into feat/sidebar-filters Jun 18, 2025
87 of 89 checks passed
@dougfabris dougfabris deleted the feat/navigation-filters-responsive branch June 18, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants