Skip to content

feat: Remove team sidepanel feature preview settings#36301

Merged
dougfabris merged 13 commits into
feat/sidebar-filtersfrom
feat/remove-team-sidepanel-settings
Jun 27, 2025
Merged

feat: Remove team sidepanel feature preview settings#36301
dougfabris merged 13 commits into
feat/sidebar-filtersfrom
feat/remove-team-sidepanel-settings

Conversation

@yash-rajpal
Copy link
Copy Markdown
Member

@yash-rajpal yash-rajpal commented Jun 25, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-100
SIDE2-101

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jun 25, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: 0472213

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 25, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36301/

Built to branch gh-pages at 2025-06-27 22:07 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (c5367ce) to head (6883416).
Report is 1 commits behind head on feat/sidebar-filters.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/sidebar-filters   #36301      +/-   ##
========================================================
+ Coverage                 64.08%   64.10%   +0.02%     
========================================================
  Files                      3151     3146       -5     
  Lines                    104900   104792     -108     
  Branches                  20008    19972      -36     
========================================================
- Hits                      67221    67179      -42     
+ Misses                    35079    35022      -57     
+ Partials                   2600     2591       -9     
Flag Coverage Δ
e2e 55.38% <57.14%> (+0.02%) ⬆️
unit 69.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal yash-rajpal marked this pull request as ready for review June 26, 2025 18:36
@yash-rajpal yash-rajpal requested review from a team as code owners June 26, 2025 18:36
Comment thread apps/meteor/client/views/room/RoomOpener.tsx
Comment thread apps/meteor/client/views/room/Sidepanel/RoomSidepanel.tsx
Comment thread apps/meteor/client/views/room/Sidepanel/RoomSidepanelLoading.tsx
Comment thread apps/meteor/client/views/room/Sidepanel/index.ts
@yash-rajpal yash-rajpal requested a review from dougfabris June 27, 2025 17:29
@dougfabris dougfabris changed the title feat: Remove Team sidepanel configurations and settings feat: Remove team sidepanel feature preview settings Jun 27, 2025
@dougfabris dougfabris force-pushed the feat/remove-team-sidepanel-settings branch from 98bceb8 to 0472213 Compare June 27, 2025 21:42
@dougfabris dougfabris merged commit 3a7835e into feat/sidebar-filters Jun 27, 2025
49 checks passed
@dougfabris dougfabris deleted the feat/remove-team-sidepanel-settings branch June 27, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants