Skip to content

feat: Sidebar filters for teams/channels/dms#36322

Merged
dougfabris merged 10 commits into
feat/sidebar-filtersfrom
feat/sidebar-filter-channels
Jul 9, 2025
Merged

feat: Sidebar filters for teams/channels/dms#36322
dougfabris merged 10 commits into
feat/sidebar-filtersfrom
feat/sidebar-filter-channels

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Jun 27, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Kapture 2025-07-01 at 20 51 03

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-22
SIDE2-23
SIDE2-24
SIDE2-97

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jun 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: 510a888

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 27, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36322/

Built to branch gh-pages at 2025-07-09 17:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 20.75472% with 84 lines in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (1a6a2f7) to head (510a888).
Report is 53 commits behind head on feat/sidebar-filters.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/sidebar-filters   #36322      +/-   ##
========================================================
- Coverage                 64.07%   64.03%   -0.04%     
========================================================
  Files                      3146     3155       +9     
  Lines                    104881   104952      +71     
  Branches                  19992    19989       -3     
========================================================
+ Hits                      67200    67208       +8     
- Misses                    35093    35159      +66     
+ Partials                   2588     2585       -3     
Flag Coverage Δ
e2e 55.24% <16.00%> (-0.16%) ⬇️
unit 69.48% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the feat/sidebar-filter-channels branch 2 times, most recently from fed2c55 to 6570cff Compare July 1, 2025 17:23
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from 2c7e4c4 to 5587173 Compare July 1, 2025 17:44
@dougfabris dougfabris force-pushed the feat/sidebar-filter-channels branch from 6570cff to 4a2c4ed Compare July 1, 2025 23:48
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from 5587173 to b8bdb23 Compare July 2, 2025 00:01
@dougfabris dougfabris force-pushed the feat/sidebar-filter-channels branch 2 times, most recently from d9929d8 to 3764b4c Compare July 2, 2025 00:07
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from b8bdb23 to 1a6a2f7 Compare July 2, 2025 14:07
@dougfabris dougfabris force-pushed the feat/sidebar-filter-channels branch from 3764b4c to 0fef39f Compare July 2, 2025 14:08
@dougfabris dougfabris marked this pull request as ready for review July 2, 2025 15:25
@dougfabris dougfabris requested a review from a team as a code owner July 2, 2025 15:25
Comment thread apps/meteor/client/views/navigation/sidepanel/tabs/SidePanelChannels.tsx Outdated
Comment thread apps/meteor/client/views/navigation/sidepanel/tabs/SidePanelTeams.tsx Outdated
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we need to handle the removal/deletion of rooms gracefully, so that the sidepanel doesn't break.

Comment thread apps/meteor/client/views/navigation/sidepanel/SidePanelRouter.tsx Outdated
@dougfabris dougfabris merged commit 0824c23 into feat/sidebar-filters Jul 9, 2025
49 checks passed
@dougfabris dougfabris deleted the feat/sidebar-filter-channels branch July 9, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants