feat: Sidebar filters for teams/channels/dms#36322
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/sidebar-filters #36322 +/- ##
========================================================
- Coverage 64.07% 64.03% -0.04%
========================================================
Files 3146 3155 +9
Lines 104881 104952 +71
Branches 19992 19989 -3
========================================================
+ Hits 67200 67208 +8
- Misses 35093 35159 +66
+ Partials 2588 2585 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
fed2c55 to
6570cff
Compare
2c7e4c4 to
5587173
Compare
6570cff to
4a2c4ed
Compare
5587173 to
b8bdb23
Compare
d9929d8 to
3764b4c
Compare
b8bdb23 to
1a6a2f7
Compare
3764b4c to
0fef39f
Compare
gabriellsh
left a comment
There was a problem hiding this comment.
As we discussed, we need to handle the removal/deletion of rooms gracefully, so that the sidepanel doesn't break.
…ription instead of throwing error
…tead of throwing error
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
Issue(s)
Steps to test or reproduce
Further comments
SIDE2-22
SIDE2-23
SIDE2-24
SIDE2-97