Skip to content

regression: await user info retrieval in notifyOnUserChange #36389

Merged
ggazzo merged 1 commit intodevelopfrom
regression/saveUserProfile
Jul 9, 2025
Merged

regression: await user info retrieval in notifyOnUserChange #36389
ggazzo merged 1 commit intodevelopfrom
regression/saveUserProfile

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 9, 2025

caused after adding the getUserInfo call

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 9, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025

⚠️ No Changeset found

Latest commit: 776ec48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.9.0 milestone Jul 9, 2025
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (3c62b9c) to head (776ec48).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36389      +/-   ##
===========================================
- Coverage    64.75%   64.75%   -0.01%     
===========================================
  Files         3156     3156              
  Lines       104909   104909              
  Branches     19965    19956       -9     
===========================================
- Hits         67938    67929       -9     
- Misses       34283    34293      +10     
+ Partials      2688     2687       -1     
Flag Coverage Δ
e2e 57.59% <ø> (+0.01%) ⬆️
unit 69.45% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36389/

Built to branch gh-pages at 2025-07-09 17:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ggazzo ggazzo marked this pull request as ready for review July 9, 2025 19:08
@ggazzo ggazzo requested a review from a team as a code owner July 9, 2025 19:08
@ggazzo ggazzo merged commit 7d15361 into develop Jul 9, 2025
88 of 90 checks passed
@ggazzo ggazzo deleted the regression/saveUserProfile branch July 9, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants