Skip to content

fix: Sidebar and sidepanel behavior in mobile view#36450

Merged
dougfabris merged 1 commit into
feat/sidebar-filtersfrom
fix/room-filters-on-mobile-view
Jul 16, 2025
Merged

fix: Sidebar and sidepanel behavior in mobile view#36450
dougfabris merged 1 commit into
feat/sidebar-filtersfrom
fix/room-filters-on-mobile-view

Conversation

@yash-rajpal
Copy link
Copy Markdown
Member

@yash-rajpal yash-rajpal commented Jul 16, 2025

Important

This change is under feature preview

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-103

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jul 16, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 16, 2025

⚠️ No Changeset found

Latest commit: 2192ff1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yash-rajpal yash-rajpal changed the title sidebar and sidepanel behavior on mobile view fix: Sidebar and sidepanel behavior in mobile view Jul 16, 2025
@yash-rajpal yash-rajpal marked this pull request as ready for review July 16, 2025 18:45
@yash-rajpal yash-rajpal requested a review from a team as a code owner July 16, 2025 18:45
@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36450/

Built to branch gh-pages at 2025-07-16 18:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (de059eb) to head (2192ff1).
Report is 1 commits behind head on feat/sidebar-filters.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/sidebar-filters   #36450      +/-   ##
========================================================
- Coverage                 64.76%   64.75%   -0.01%     
========================================================
  Files                      3167     3167              
  Lines                    105159   105146      -13     
  Branches                  20026    20023       -3     
========================================================
- Hits                      68105    68091      -14     
+ Misses                    34466    34465       -1     
- Partials                   2588     2590       +2     
Flag Coverage Δ
e2e 55.81% <ø> (-0.02%) ⬇️
unit 70.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris merged commit 08c67cd into feat/sidebar-filters Jul 16, 2025
53 of 55 checks passed
@dougfabris dougfabris deleted the fix/room-filters-on-mobile-view branch July 16, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants