Skip to content

chore: Show MAC limit warning on omnichannel rooms#36517

Merged
yash-rajpal merged 4 commits into
feat/sidebar-filtersfrom
feat/OC-mac-limit-warning
Jul 24, 2025
Merged

chore: Show MAC limit warning on omnichannel rooms#36517
yash-rajpal merged 4 commits into
feat/sidebar-filtersfrom
feat/OC-mac-limit-warning

Conversation

@yash-rajpal
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

image

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jul 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 24, 2025

⚠️ No Changeset found

Latest commit: 8d2c4d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review July 24, 2025 14:37
@yash-rajpal yash-rajpal requested a review from a team as a code owner July 24, 2025 14:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36517/

Built to branch gh-pages at 2025-07-24 15:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/sidebar-filters@9baa922). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             feat/sidebar-filters   #36517   +/-   ##
=======================================================
  Coverage                        ?   64.98%           
=======================================================
  Files                           ?     3180           
  Lines                           ?   106495           
  Branches                        ?    20307           
=======================================================
  Hits                            ?    69208           
  Misses                          ?    34706           
  Partials                        ?     2581           
Flag Coverage Δ
e2e 55.66% <15.38%> (?)
unit 70.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal yash-rajpal merged commit 7d2fda6 into feat/sidebar-filters Jul 24, 2025
71 of 73 checks passed
@yash-rajpal yash-rajpal deleted the feat/OC-mac-limit-warning branch July 24, 2025 16:41
dougfabris added a commit that referenced this pull request Jul 25, 2025
Co-authored-by: dougfabris <devfabris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants