Skip to content

chore: Delete stale fork of kadira:flow-router#36599

Merged
kodiakhq[bot] merged 1 commit into
developfrom
chore/kadira-flow-router
Aug 1, 2025
Merged

chore: Delete stale fork of kadira:flow-router#36599
kodiakhq[bot] merged 1 commit into
developfrom
chore/kadira-flow-router

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Aug 1, 2025

Proposed changes (including videos or screenshots)

It removes the fork of the 3rd-party Meteor package kadira:flow-router since it was replaced by ostrio:flow-router-extra.

Issue(s)

ARCH-1731

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Aug 1, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 1, 2025

⚠️ No Changeset found

Latest commit: 6995384

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan requested a review from a team August 1, 2025 15:45
@tassoevan tassoevan added this to the 7.10.0 milestone Aug 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36599/

Built to branch gh-pages at 2025-08-01 15:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.68%. Comparing base (244a614) to head (6995384).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36599      +/-   ##
===========================================
+ Coverage    65.66%   65.68%   +0.02%     
===========================================
  Files         3195     3195              
  Lines       106699   106699              
  Branches     20316    20319       +3     
===========================================
+ Hits         70063    70086      +23     
+ Misses       33986    33972      -14     
+ Partials      2650     2641       -9     
Flag Coverage Δ
e2e 56.96% <ø> (+0.01%) ⬆️
unit 71.27% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan marked this pull request as ready for review August 1, 2025 17:33
@tassoevan tassoevan requested a review from a team August 1, 2025 17:33
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 1, 2025
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 1, 2025
@kodiakhq kodiakhq Bot merged commit d2a60c3 into develop Aug 1, 2025
53 checks passed
@kodiakhq kodiakhq Bot deleted the chore/kadira-flow-router branch August 1, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants