Skip to content

chore: Enhance error handling Rest definitions#36706

Merged
ggazzo merged 3 commits into
developfrom
chore/not-found-def
Aug 13, 2025
Merged

chore: Enhance error handling Rest definitions#36706
ggazzo merged 3 commits into
developfrom
chore/not-found-def

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Aug 13, 2025

…e and schema (#36699)
https://rocketchat.atlassian.net/browse/ARCH-1772

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 13, 2025

⚠️ No Changeset found

Latest commit: 70d239b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Aug 13, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@ggazzo ggazzo changed the title feat: Enhance error handling by introducing NotFoundErrorResponse typ… chore: Enhance error handling Rest definitions Aug 13, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.78%. Comparing base (e5cad0d) to head (70d239b).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36706      +/-   ##
===========================================
- Coverage    65.80%   65.78%   -0.03%     
===========================================
  Files         3233     3233              
  Lines       108092   108113      +21     
  Branches     20570    20573       +3     
===========================================
- Hits         71129    71121       -8     
- Misses       34307    34332      +25     
- Partials      2656     2660       +4     
Flag Coverage Δ
e2e 57.12% <ø> (-0.03%) ⬇️
unit 71.25% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…dler and appLogsExportHandler for improved type safety
@ggazzo ggazzo added this to the 7.10.0 milestone Aug 13, 2025
@ggazzo ggazzo marked this pull request as ready for review August 13, 2025 21:42
@ggazzo ggazzo requested review from a team as code owners August 13, 2025 21:42
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Aug 13, 2025
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 13, 2025
@ggazzo ggazzo merged commit f018265 into develop Aug 13, 2025
22 of 23 checks passed
@ggazzo ggazzo deleted the chore/not-found-def branch August 13, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants