Skip to content

chore: Inherit environment variables in deno cache build script#36782

Merged
dionisio-bot[bot] merged 1 commit intoRocketChat:developfrom
VergeDX:patch-1
Apr 6, 2026
Merged

chore: Inherit environment variables in deno cache build script#36782
dionisio-bot[bot] merged 1 commit intoRocketChat:developfrom
VergeDX:patch-1

Conversation

@VergeDX
Copy link
Copy Markdown
Contributor

@VergeDX VergeDX commented Aug 25, 2025

Proposed changes (including videos or screenshots)

When building Rocket.Chat, this step's deno cache will not use env var HTTP_PROXY and HTTPS_PROXY because they were replaced.

@VergeDX VergeDX requested a review from a team as a code owner August 25, 2025 10:03
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Aug 25, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 25, 2025

⚠️ No Changeset found

Latest commit: 151f5f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 25, 2025

CLA assistant check
All committers have signed the CLA.

@VergeDX VergeDX changed the title chore[packages/apps-engine/scripts/deno-cache.js]: Preserve env var. chore: Inherit environment variables in deno cache build script Aug 26, 2025
@arpsyapathy
Copy link
Copy Markdown

+1
same problem

d-gubert

This comment was marked as resolved.

@arpsyapathy
Copy link
Copy Markdown

Hey, thanks for bringing this up. Legitimate problem, I just disagree with the solution :)

Agree with you. Should I just continue the variables after PATH, separated by commas?

@d-gubert
Copy link
Copy Markdown
Member

Hey, thanks for bringing this up. Legitimate problem, I just disagree with the solution :)

Agree with you. Should I just continue the variables after PATH, separated by commas?

Hey, no don't worry about the coment, I misread the modified file and thought the changes had been applied to the runtime. Since it's for the build script, we don't need to worry too much about environment ;)

@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Mar 23, 2026
@d-gubert d-gubert added this to the 8.4.0 milestone Mar 23, 2026
@dionisio-bot dionisio-bot bot enabled auto-merge April 1, 2026 19:40
@d-gubert
Copy link
Copy Markdown
Member

d-gubert commented Apr 1, 2026

@coderabbitai ignore

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Note

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

✅ Actions performed

Reviews paused.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.53%. Comparing base (8ebf44b) to head (151f5f5).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36782      +/-   ##
===========================================
- Coverage    70.57%   70.53%   -0.05%     
===========================================
  Files         3270     3270              
  Lines       116766   116766              
  Branches     21091    21060      -31     
===========================================
- Hits         82409    82359      -50     
- Misses       32304    32348      +44     
- Partials      2053     2059       +6     
Flag Coverage Δ
e2e 60.46% <ø> (-0.02%) ⬇️
e2e-api 49.00% <ø> (-0.07%) ⬇️
unit 70.96% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dionisio-bot dionisio-bot bot added this pull request to the merge queue Apr 6, 2026
Merged via the queue into RocketChat:develop with commit 01159c0 Apr 6, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants