chore: Inherit environment variables in deno cache build script#36782
chore: Inherit environment variables in deno cache build script#36782dionisio-bot[bot] merged 1 commit intoRocketChat:developfrom
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
+1 |
Agree with you. Should I just continue the variables after PATH, separated by commas? |
Hey, no don't worry about the coment, I misread the modified file and thought the changes had been applied to the runtime. Since it's for the build script, we don't need to worry too much about environment ;) |
|
@coderabbitai ignore |
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Actions performedReviews paused. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36782 +/- ##
===========================================
- Coverage 70.57% 70.53% -0.05%
===========================================
Files 3270 3270
Lines 116766 116766
Branches 21091 21060 -31
===========================================
- Hits 82409 82359 -50
- Misses 32304 32348 +44
- Partials 2053 2059 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
When building Rocket.Chat, this step's
deno cachewill not use env varHTTP_PROXYandHTTPS_PROXYbecause they were replaced.