Skip to content

refactor: Livechat webhook retry & timeout logic#36793

Merged
kodiakhq[bot] merged 8 commits into
developfrom
fix/delivery-errors
Sep 2, 2025
Merged

refactor: Livechat webhook retry & timeout logic#36793
kodiakhq[bot] merged 8 commits into
developfrom
fix/delivery-errors

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Aug 25, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-314

Steps to test or reproduce

Further comments

Basically, we were awaiting the response of the first webhook call. This is not bad in circumstances where the webhook is answering like a normal webhook.

If, however, the webhook was not working correctly or couldn't handle the load, we would wait for TIMEOUT before resolving the message being sent or the action being performed.

Also, the webhook was retrying on cases where it shouldn't. Like for example, when it was returning 400~ status codes.

Finally, tests.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Aug 25, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 25, 2025

⚠️ No Changeset found

Latest commit: f943117

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.34%. Comparing base (078362e) to head (f943117).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36793      +/-   ##
===========================================
- Coverage    66.35%   66.34%   -0.02%     
===========================================
  Files         3322     3323       +1     
  Lines       111249   111282      +33     
  Branches     21075    21081       +6     
===========================================
+ Hits         73824    73834      +10     
- Misses       34743    34753      +10     
- Partials      2682     2695      +13     
Flag Coverage Δ
e2e 57.67% <ø> (-0.07%) ⬇️
unit 71.63% <81.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman force-pushed the fix/delivery-errors branch from 1d2897b to 927b371 Compare August 29, 2025 15:10
@KevLehman KevLehman changed the title fix: Visitor update failing with leadCapture feature enabled fix: Livechat webhook retry & timeout logic Aug 29, 2025
@KevLehman KevLehman changed the title fix: Livechat webhook retry & timeout logic refactor: Livechat webhook retry & timeout logic Aug 29, 2025
@KevLehman KevLehman added this to the 7.11.0 milestone Aug 29, 2025
@KevLehman KevLehman marked this pull request as ready for review August 29, 2025 17:50
@KevLehman KevLehman requested review from a team as code owners August 29, 2025 17:50
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Sep 2, 2025
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 2, 2025
@kodiakhq kodiakhq Bot merged commit ccfae1c into develop Sep 2, 2025
87 of 89 checks passed
@kodiakhq kodiakhq Bot deleted the fix/delivery-errors branch September 2, 2025 17:24
@scuciatto
Copy link
Copy Markdown
Member

/backport 7.10.4

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Nov 7, 2025

Pull request #37433 added to Project: "Patch 7.10.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants