refactor: Livechat webhook retry & timeout logic#36793
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36793 +/- ##
===========================================
- Coverage 66.35% 66.34% -0.02%
===========================================
Files 3322 3323 +1
Lines 111249 111282 +33
Branches 21075 21081 +6
===========================================
+ Hits 73824 73834 +10
- Misses 34743 34753 +10
- Partials 2682 2695 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1d2897b to
927b371
Compare
|
/backport 7.10.4 |
|
Pull request #37433 added to Project: "Patch 7.10.4" |
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-314
Steps to test or reproduce
Further comments
Basically, we were awaiting the response of the first webhook call. This is not bad in circumstances where the webhook is answering like a normal webhook.
If, however, the webhook was not working correctly or couldn't handle the load, we would wait for
TIMEOUTbefore resolving the message being sent or the action being performed.Also, the webhook was retrying on cases where it shouldn't. Like for example, when it was returning 400~ status codes.
Finally, tests.