Skip to content

chore: Move helper to E2E test#37546

Merged
ggazzo merged 1 commit into
developfrom
chore/move-test-helper
Nov 18, 2025
Merged

chore: Move helper to E2E test#37546
ggazzo merged 1 commit into
developfrom
chore/move-test-helper

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Nov 17, 2025

Proposed changes (including videos or screenshots)

It moves unused function referenced by an E2E test.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 7.13.0 milestone Nov 17, 2025
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Nov 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 17, 2025

⚠️ No Changeset found

Latest commit: 4f0022a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/move-test-helper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 17, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 367MiB 355MiB +12MiB
omnichannel-transcript-service 141MiB 141MiB -1.2KiB
queue-worker-service 141MiB 141MiB +904B
ddp-streamer-service 127MiB 127MiB +339B
account-service 114MiB 114MiB +2.4KiB
stream-hub-service 111MiB 111MiB +656B
authorization-service 111MiB 111MiB -167B
presence-service 111MiB 111MiB +1.4KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 00:45 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14]
  line "presence-service" [0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14]
  line "rocketchat" [0.36, 0.36, 0.35, 0.36]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 3 days):

  • 📊 Average: 1.4GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37546
  • Baseline: develop
  • Timestamp: 2025-11-18 00:45:45 UTC
  • Historical data points: 3

Updated: Tue, 18 Nov 2025 00:45:45 GMT

@tassoevan tassoevan force-pushed the chore/move-test-helper branch from 944c8b3 to 4f0022a Compare November 18, 2025 00:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.97%. Comparing base (09551f9) to head (4f0022a).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37546      +/-   ##
===========================================
- Coverage    68.99%   68.97%   -0.03%     
===========================================
  Files         3358     3358              
  Lines       114215   114215              
  Branches     20534    20534              
===========================================
- Hits         78798    78775      -23     
- Misses       33329    33348      +19     
- Partials      2088     2092       +4     
Flag Coverage Δ
e2e 57.43% <ø> (+0.02%) ⬆️
e2e-api 42.79% <ø> (-1.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan marked this pull request as ready for review November 18, 2025 12:38
@tassoevan tassoevan requested a review from a team as a code owner November 18, 2025 12:38
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 18, 2025
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 18, 2025
@ggazzo ggazzo merged commit 8a6cae6 into develop Nov 18, 2025
52 checks passed
@ggazzo ggazzo deleted the chore/move-test-helper branch November 18, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants