Skip to content

Conversation

@rodrigok
Copy link
Member

@rodrigok rodrigok commented Nov 21, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD pipeline infrastructure to improve build performance and consistency across different system architectures. Enhanced cache key generation in build workflows to optimize cache lookup efficiency, reduce redundant rebuilds, and ensure development builds on different systems access appropriate cached artifacts.

✏️ Tip: You can customize this high-level summary in your review settings.

@rodrigok rodrigok requested a review from a team as a code owner November 21, 2025 17:32
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.14.0, but it targets 7.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: 0d87cff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Caution

Review failed

The head commit changed during the review from 2b561bf to 0d87cff.

Walkthrough

The PR reorders cache key components across GitHub Actions configuration files, consistently placing runner.arch before runner.os in cache keys throughout meteor-build, setup-node, setup-playwright actions, and the main CI workflow. Additionally, the github.run_id suffix is removed from the node-modules cache key in setup-node.

Changes

Cohort / File(s) Summary
Arch-before-OS cache key reordering
.github/actions/meteor-build/action.yml, .github/actions/setup-playwright/action.yml, .github/workflows/ci.yml
Reorders cache key components to place ${{ runner.arch }} before ${{ runner.os }} across multiple cache keys and their restore-keys for consistency. Updates primary keys and corresponding restore-keys for parity.
Node-modules cache key reordering and run_id removal
.github/actions/setup-node/action.yml
Reorders cache key to place ${{ runner.arch }} before ${{ runner.os }} and removes the ${{ github.run_id }} suffix from the node-modules cache key. Updates both primary key and commented alternative key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Consistency verification: Ensure the arch-before-OS ordering is applied uniformly across all affected files
  • Cache impact assessment: Verify understanding of how the new key ordering affects cache hit rates across different architectures
  • Completeness check: Confirm all cache keys and restore-keys have been updated consistently

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo
  • sampaiodiego

Poem

🐰 The cache keys dance and swap their place,
Arch before OS sets the pace!
Run-ids fade as order's refined,
Swift CI builds we're sure to find! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reordering OS and architecture components in cache keys across multiple GitHub Actions workflows to support multi-architecture builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ggazzo
ggazzo previously approved these changes Nov 21, 2025
@ggazzo ggazzo added this to the 7.14.0 milestone Nov 21, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 21, 2025
@rodrigok rodrigok force-pushed the chore/ci-cache branch 2 times, most recently from 2b561bf to 0d87cff Compare November 24, 2025 13:51
@github-actions
Copy link
Contributor

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +577B
queue-worker-service 132MiB 132MiB +90B
ddp-streamer-service 127MiB 127MiB -245B
account-service 114MiB 114MiB +427B
stream-hub-service 111MiB 111MiB -868B
authorization-service 111MiB 111MiB +305B
presence-service 111MiB 111MiB -378B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 14:12 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 6 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37575
  • Baseline: develop
  • Timestamp: 2025-11-24 14:12:57 UTC
  • Historical data points: 6

Updated: Mon, 24 Nov 2025 14:12:58 GMT

@ggazzo ggazzo merged commit 4102f12 into develop Nov 24, 2025
107 of 112 checks passed
@ggazzo ggazzo deleted the chore/ci-cache branch November 24, 2025 14:57
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.84%. Comparing base (5ef03e2) to head (0d87cff).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37575      +/-   ##
===========================================
- Coverage    68.86%   68.84%   -0.03%     
===========================================
  Files         3360     3361       +1     
  Lines       114339   114343       +4     
  Branches     20560    20619      +59     
===========================================
- Hits         78741    78715      -26     
- Misses       33502    33536      +34     
+ Partials      2096     2092       -4     
Flag Coverage Δ
e2e 57.33% <ø> (-0.08%) ⬇️
e2e-api 42.27% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants