fix: wrap omnichannel transfer comments in system messages#37847
fix: wrap omnichannel transfer comments in system messages#37847RakshithaMH24 wants to merge 3 commits into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughSystemMessage JSX restructured: the message body rendering is wrapped with explicit styles (whiteSpace: 'normal', overflowWrap: 'anywhere') and the timestamp was moved into its own MessageSystemTimestamp element placed on a separate line outside the body block. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/meteor/client/components/message/variants/SystemMessage.tsx (1)
91-106: Text wrapping fix looks good; consider removing redundant property.The explicit wrapping styles successfully address the truncation issue. The combination of
whiteSpace: 'normal'andoverflowWrap: 'anywhere'will ensure long transfer comments wrap properly across multiple lines.However,
wordBreak: 'break-word'is redundant alongsideoverflowWrap: 'anywhere'and is deprecated in modern CSS. Consider simplifying:<MessageSystemBody data-qa-type='system-message-body' style={{ whiteSpace: 'normal', - wordBreak: 'break-word', overflowWrap: 'anywhere', }} >
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/meteor/client/components/message/variants/SystemMessage.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/components/message/variants/SystemMessage.tsx
🧠 Learnings (1)
📓 Common learnings
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37419
File: packages/i18n/src/locales/en.i18n.json:918-921
Timestamp: 2025-11-19T18:20:07.720Z
Learning: Repo: RocketChat/Rocket.Chat — i18n/formatting
Learning: This repository uses a custom message formatting parser in UI blocks/messages; do not assume standard Markdown rules. For keys like Call_ended_bold, Call_not_answered_bold, Call_failed_bold, and Call_transferred_bold in packages/i18n/src/locales/en.i18n.json, retain the existing single-asterisk emphasis unless maintainers request otherwise.
Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37408
File: apps/meteor/client/views/admin/ABAC/useRoomAttributeOptions.tsx:53-69
Timestamp: 2025-11-10T19:06:20.146Z
Learning: In the Rocket.Chat repository, do not provide suggestions or recommendations about code sections marked with TODO comments. The maintainers have already identified these as future work and external reviewers lack the full context about implementation plans and timing.
Thanks for taking a look! Happy to address any feedback or changes if needed. |
|
Hi Rocket.Chat team All requested changes have been addressed:
Kindly requesting a frontend code-owner review when available. |
Problem
Omnichannel transfer comments were rendered in a single line and truncated with ellipsis.
Solution
Updated SystemMessage body styling to allow proper text wrapping using CSS
(white-space, word-break, overflow-wrap).
Result
Long transfer comments now display correctly across multiple lines.
Summary by CodeRabbit