fix(livechat)#38512/Rocket.Chat

[dhruvjamwal]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Bug Fixes
  • Improved validation for omnichannel trigger name and description fields to prevent empty or whitespace-only submissions
  • Enhanced message field validation to ensure non-empty values
  • Better error messaging and display for form input validation

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project
• This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 753cb04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

Input validation enhancements were added to two omnichannel trigger form components. Name, description, and message fields now include trim-based validation rules that ensure non-empty values, with corresponding error display and accessibility improvements for user feedback.

Changes

Cohort / File(s)	Summary
Form Validation Enhancements apps/meteor/client/views/omnichannel/triggers/EditTrigger.tsx, apps/meteor/client/views/omnichannel/triggers/actions/SendMessageActionForm.tsx	Added trim-based validation rules to name, description, and message fields. EditTrigger enhanced with error state rendering, FieldError component, and aria attributes for accessibility. SendMessageActionForm extended controller rules for message field validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A hop through the forms, trim and true,
No empty whispers shall slip on through,
With aria-live and error display,
Our messages dance the validation way! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix(livechat)#38512/Rocket.Chat' is vague and does not clearly describe the specific changes. It uses only an issue reference without explaining what the fix actually does.	Use a more descriptive title like 'fix: Add whitespace validation to livechat trigger forms' to clearly communicate the main change to reviewers.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files