Skip to content

Conversation

@ScriptShah
Copy link
Contributor

@ScriptShah ScriptShah commented Feb 10, 2026

Proposed changes (including videos or screenshots)

This pull request fixes a UI inconsistency in the Omnichannel → Managers page where the loading skeleton rendered fewer columns than the actual table header.

While data was loading, the table header displayed four columns, but the loading skeleton was configured to render only two columns. This caused a visible layout mismatch and made the loading state appear misaligned.

What was changed

  • Updated the Managers table loading state to render the same number of skeleton columns as the table header.

Why this change is needed

Best practice for loading skeletons is to mirror the final layout as closely as possible. Aligning the number of skeleton columns with the visible header columns ensures visual consistency and avoids layout shifts during loading.

📸 Screenshot attached showing the mismatch before the fix.
image

📸 Screenshot attached showing the mismatch after the fix.
image


Issue(s)

Closes #38570


Steps to test or reproduce

  1. Navigate to Home → Administration → Omnichannel → Managers.
  2. Reload the page or trigger the loading state.
  3. Observe the loading skeleton and table header.
  4. Verify that the number of skeleton columns matches the table header columns during loading.

Further comments

This is a small, isolated UI fix that does not affect application logic or behavior outside of the loading state. No changeset is included, as this change does not require a version bump.

COMM-129

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the managers table loading skeleton to display four columns so it aligns with the table headers.
    • Fix improves visual consistency and readability in the managers view while data is loading, reducing layout confusion for users.

@ScriptShah ScriptShah requested a review from a team as a code owner February 10, 2026 10:32
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 10, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

🦋 Changeset detected

Latest commit: f95c055

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@ScriptShah
Copy link
Contributor Author

Hi team 👋
This is my first PR to Rocket.Chat, with a very small UI fix (1-line change). I’d really appreciate it if you could take a quick look and forward it toward merge when possible.

Thank you for maintaining the project and the community 🙏

@dougfabris dougfabris added the contrib: valid A valid contribution where maintainers will review based on priority label Feb 10, 2026
@dougfabris dougfabris added this to the 8.2.0 milestone Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.36%. Comparing base (fbc4935) to head (f95c055).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #38579      +/-   ##
===========================================
- Coverage    70.42%   70.36%   -0.06%     
===========================================
  Files         3174     3174              
  Lines       110882   110882              
  Branches     19997    19940      -57     
===========================================
- Hits         78088    78027      -61     
- Misses       30755    30811      +56     
- Partials      2039     2044       +5     
Flag Coverage Δ
e2e 60.45% <ø> (+0.04%) ⬆️
e2e-api 47.77% <ø> (-1.03%) ⬇️
unit 71.35% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dougfabris
dougfabris previously approved these changes Feb 10, 2026
@dougfabris
Copy link
Member

@ScriptShah could you add a changeset for your fix?

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Walkthrough

Updates the Managers table loading skeleton to render four header cells (matching the table's four-column header) and adds a patch-level changeset entry documenting the fix for @rocket.chat/meteor.

Changes

Cohort / File(s) Summary
Changeset Entry
​.changeset/hot-bikes-sin.md
Adds a patch-level changeset documenting the fix: managers table loading skeleton column mismatch.
Managers Table Component
apps/meteor/client/views/omnichannel/managers/ManagersTable.tsx
Adjusts loading state rendering so the skeleton shows 4 header cells (was 2), aligning skeleton with actual table header.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Four little columns stand in a row,
The skeleton joins them, steady and slow,
No gaps, no wobbles, the layout's true,
A tiny fix — a clearer view! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: fixing the managers table loading skeleton columns to align with the table header.
Linked Issues check ✅ Passed The code changes directly address the requirements in issue #38570: updating the ManagersTable loading state to render 4 skeleton columns instead of 2, matching the 4-column header structure.
Out of Scope Changes check ✅ Passed All changes are scoped to the specific UI fix: the changeset documents the patch, and the ManagersTable.tsx modification addresses only the skeleton column mismatch without affecting other functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca78be and f95c055.

📒 Files selected for processing (1)
  • .changeset/hot-bikes-sin.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/hot-bikes-sin.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: 📦 Build Packages

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Feb 11, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 11, 2026
@kodiakhq kodiakhq bot merged commit a9a5846 into RocketChat:develop Feb 11, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contrib: valid A valid contribution where maintainers will review based on priority stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Managers table loading skeleton renders incorrect number of columns

2 participants