Skip to content

fix: markdown breaking on bracketed text between hyperlinks#38629

Merged
ggazzo merged 9 commits intodevelopfrom
copilot/fix-specific-case-and-add-tests
Feb 12, 2026
Merged

fix: markdown breaking on bracketed text between hyperlinks#38629
ggazzo merged 9 commits intodevelopfrom
copilot/fix-specific-case-and-add-tests

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

This pull request addresses issues with markdown parsing when text in square brackets appears between hyperlinks, ensuring that such cases no longer break the markdown structure. The changes include grammar improvements, bug fixes, and new tests to cover these scenarios.

Markdown parsing improvements:

Bug fixes:

  • Added a patch note describing the markdown fix for square bracketed text between hyperlinks in .changeset/fix-markdown-between-links.md.

Test coverage:

  • Added new test cases in link.test.ts to verify correct parsing of bracketed text between links and multiple links with bracketed text between them.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Task: ARCH-1945

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 12, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

🦋 Changeset detected

Latest commit: 32700d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/message-parser Patch
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
@rocket.chat/pdf-worker Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/models Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI changed the title [WIP] Fix issue and add tests for specific case Port fix to repository and add tests for specific case Feb 12, 2026
Copilot AI requested a review from ggazzo February 12, 2026 03:42
Copilot AI and others added 4 commits February 12, 2026 03:47
…ing between links

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot AI changed the title Port fix to repository and add tests for specific case Fix markdown parser breaking on bracketed text between hyperlinks Feb 12, 2026
@ggazzo ggazzo changed the title Fix markdown parser breaking on bracketed text between hyperlinks fix: markdown breaking on bracketed text between hyperlinks Feb 12, 2026
@ggazzo ggazzo added this to the 8.2.0 milestone Feb 12, 2026
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB +11MiB
rocketchat 360MiB 349MiB +11MiB
omnichannel-transcript-service 134MiB 134MiB -2.0KiB
queue-worker-service 134MiB 134MiB -944B
ddp-streamer-service 128MiB 128MiB +1.4KiB
account-service 115MiB 115MiB +2.1KiB
authorization-service 112MiB 112MiB -621B
presence-service 112MiB 112MiB +56B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/12 03:41", "02/12 04:58 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
Loading

Statistics (last 30 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.4GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-38629
  • Baseline: develop
  • Timestamp: 2026-02-12 04:58:10 UTC
  • Historical data points: 30

Updated: Thu, 12 Feb 2026 04:58:11 GMT

…eaking parsing

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot AI changed the title fix: markdown breaking on bracketed text between hyperlinks Fix markdown parser: prevent LinkTitle from consuming text across link boundaries Feb 12, 2026
@ggazzo ggazzo changed the title Fix markdown parser: prevent LinkTitle from consuming text across link boundaries fix: markdown prevent LinkTitle from consuming text across link boundaries Feb 12, 2026
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot AI changed the title fix: markdown prevent LinkTitle from consuming text across link boundaries Restore package.json and jest.config.ts to original state Feb 12, 2026
@ggazzo ggazzo changed the title Restore package.json and jest.config.ts to original state fix: markdown breaking on bracketed text between hyperlinks Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.44%. Comparing base (f5d4ecd) to head (32700d6).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #38629      +/-   ##
===========================================
- Coverage    70.45%   70.44%   -0.02%     
===========================================
  Files         3174     3174              
  Lines       111005   111059      +54     
  Branches     20000    19990      -10     
===========================================
+ Hits         78207    78232      +25     
- Misses       30758    30784      +26     
- Partials      2040     2043       +3     
Flag Coverage Δ
unit 71.42% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo marked this pull request as ready for review February 12, 2026 14:11
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@ggazzo
Copy link
Member

ggazzo commented Feb 12, 2026

/jira ARCH

1 similar comment
@ggazzo
Copy link
Member

ggazzo commented Feb 12, 2026

/jira ARCH

@ggazzo
Copy link
Member

ggazzo commented Feb 12, 2026

/jira ARCH-1935

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Feb 12, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 12, 2026
@ggazzo ggazzo merged commit 098f0a7 into develop Feb 12, 2026
57 of 60 checks passed
@ggazzo ggazzo deleted the copilot/fix-specific-case-and-add-tests branch February 12, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants