fix: removed redundant hindi translation file#38917
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
WalkthroughMigrates Hindi locale usage from the generic Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/livechat/src/supportedLocales.ts">
<violation number="1" location="packages/livechat/src/supportedLocales.ts:27">
P2: Removing `'hi'` from `supportedLocales` breaks existing `hi` language settings: the locale resolver only matches against this list and will now fall back to `en-US` without any aliasing to `hi-IN`, causing Hindi users to lose localized date formatting.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Issue
In Preferences → Localization → Language, there are two Hindi language options:
Out of these, "Hindi" makes very minimal (almost zero) changes and appears to be redundant.
Steps to Test / Reproduce
Expected Behavior
The localization option should meaningfully translate the interface.
Actual Behavior
The Hindi localization file provides minimal translations and does not significantly change the UI, making it redundant.
Suggested Solution
Remove the redundant Hindi localization and retain Hindi (India), which works correctly and provides proper translations.
23.02.2026_10.36.36_REC.mp4
Fixes #38916
Summary by CodeRabbit