docs: fix broken Storybook link in fuselage-ui-kit README#39136
Closed
successbyte wants to merge 1 commit into
Closed
docs: fix broken Storybook link in fuselage-ui-kit README#39136successbyte wants to merge 1 commit into
successbyte wants to merge 1 commit into
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Contributor
WalkthroughUpdates to the README file correct broken documentation links and badge URLs, redirecting them to valid Storybook pages and updated repository paths to reflect current branding and hosting structure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/fuselage-ui-kit/README.md`:
- Line 15: The npm badge links in the README currently point to
`@rocket.chat/icons`; update the hrefs for the `npm@latest` and `npm@next` badges
so they target the displayed package (`@rocket.chat/fuselage-ui-kit`) instead of
`@rocket.chat/icons` (i.e., change the two npm badge URLs to reference the
`@rocket.chat/fuselage-ui-kit` package with the same /v/latest and /v/next paths).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/fuselage-ui-kit/README.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-02-24T19:05:56.710Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
Applied to files:
packages/fuselage-ui-kit/README.md
📚 Learning: 2025-11-17T15:07:13.273Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37398
File: packages/fuselage-ui-kit/src/surfaces/FuselageSurfaceRenderer.tsx:357-363
Timestamp: 2025-11-17T15:07:13.273Z
Learning: In packages/fuselage-ui-kit/src/surfaces/FuselageSurfaceRenderer.tsx, IconElement is a presentational, non-actionable element that does not require wrapping in AppIdProvider, similar to plain_text and mrkdwn renderers. Only actionable elements (those with actions, actionId, or interactive behavior) should be wrapped in AppIdProvider.
Applied to files:
packages/fuselage-ui-kit/README.md
| --- | ||
|
|
||
| [](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat.Fuselage/fuselage-ui-kit)   | ||
| [](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)   |
Contributor
There was a problem hiding this comment.
Fix npm badge targets to point to the correct package.
The npm@latest / npm@next badges show @rocket.chat/fuselage-ui-kit but currently link to @rocket.chat/icons. Please align the hrefs with the displayed package.
Suggested patch
-[](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)  
+[](https://www.npmjs.com/package/@rocket.chat/fuselage-ui-kit/v/latest) [](https://www.npmjs.com/package/@rocket.chat/fuselage-ui-kit/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)  📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| [](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)   | |
| [](https://www.npmjs.com/package/@rocket.chat/fuselage-ui-kit/v/latest) [](https://www.npmjs.com/package/@rocket.chat/fuselage-ui-kit/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)   |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/fuselage-ui-kit/README.md` at line 15, The npm badge links in the
README currently point to `@rocket.chat/icons`; update the hrefs for the
`npm@latest` and `npm@next` badges so they target the displayed package
(`@rocket.chat/fuselage-ui-kit`) instead of `@rocket.chat/icons` (i.e., change
the two npm badge URLs to reference the `@rocket.chat/fuselage-ui-kit` package
with the same /v/latest and /v/next paths).
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/fuselage-ui-kit/README.md">
<violation number="1" location="packages/fuselage-ui-kit/README.md:15">
P2: The npm badge links incorrectly point to `@rocket.chat/icons` instead of `@rocket.chat/fuselage-ui-kit`. The badge images correctly display `@rocket.chat/fuselage-ui-kit` versions, but the anchor links navigate to the wrong package page.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| --- | ||
|
|
||
| [](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat.Fuselage/fuselage-ui-kit)   | ||
| [](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)   |
Contributor
There was a problem hiding this comment.
P2: The npm badge links incorrectly point to @rocket.chat/icons instead of @rocket.chat/fuselage-ui-kit. The badge images correctly display @rocket.chat/fuselage-ui-kit versions, but the anchor links navigate to the wrong package page.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/fuselage-ui-kit/README.md, line 15:
<comment>The npm badge links incorrectly point to `@rocket.chat/icons` instead of `@rocket.chat/fuselage-ui-kit`. The badge images correctly display `@rocket.chat/fuselage-ui-kit` versions, but the anchor links navigate to the wrong package page.</comment>
<file context>
@@ -12,7 +12,7 @@
---
-[](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat.Fuselage/fuselage-ui-kit)  
+[](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)  
   
</file context>
Suggested change
| [](https://www.npmjs.com/package/@rocket.chat/icons/v/latest) [](https://www.npmjs.com/package/@rocket.chat/icons/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)   | |
| [](https://www.npmjs.com/package/@rocket.chat/fuselage-ui-kit/v/latest) [](https://www.npmjs.com/package/@rocket.chat/fuselage-ui-kit/v/next)  [](https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/)   |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes a broken Storybook badge link in
packages/fuselage-ui-kit/README.md.https://rocketchat.github.io/Rocket.Chat.Fuselage/fuselage-ui-kithttps://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/This is a docs-only, one-line change.
Issue(s)
Closes #39134
Steps to test or reproduce
https://rocketchat.github.io/Rocket.Chat/develop/fuselage-ui-kit/https://rocketchat.github.io/Rocket.Chat.Fuselage/fuselage-ui-kitFurther comments
No code behavior changes. README link fix only.
Summary by CodeRabbit