refactor: standardize TwoFactorRequiredModal using GenericModal#39148
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
🔇 Additional comments (2)
WalkthroughRefactored TwoFactorRequiredModal to replace fuselage Modal components with GenericModal from ui-client. Simplified component structure by consolidating modal implementation while maintaining existing API and user-facing behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #39146
Replaced raw fuselage Modal primitives (Modal,
ModalHeader,ModalTitle,ModalContent,ModalFooter,ModalFooterControllers, Button) with the standardized GenericModal component from@rocket.chat/ui-clientin TwoFactorRequiredModal.This follows the same pattern established in #38334, #38431, and #38433.
Changes
title,confirmText,onConfirm,onClose)@rocket.chat/fuselagemodal importsScreenshots
No UI changes — the modal renders identically using GenericModal's internal layout.
Summary by CodeRabbit