refactor: Use RequiredField util for username enforcement in API definition#39292
Merged
ggazzo merged 2 commits intochore/username-apifrom Mar 3, 2026
Merged
refactor: Use RequiredField util for username enforcement in API definition#39292ggazzo merged 2 commits intochore/username-apifrom
RequiredField util for username enforcement in API definition#39292ggazzo merged 2 commits intochore/username-apifrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
…cement Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to enforce username requirement with RequiredField util
refactor: Use Mar 3, 2026
RequiredField util for username enforcement in API definition
ggazzo
added a commit
that referenced
this pull request
Mar 3, 2026
…finition (#39292) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the verbose inline type
Omit<IUser, 'username'> & Required<Pick<IUser, 'username'>>with the existingRequiredFieldutility from@rocket.chat/core-typings, as flagged in review.Changes
apps/meteor/app/api/server/definition.tsRequiredFieldfrom@rocket.chat/core-typingsRequiredField<IUser, 'username'>No behaviour change —
RequiredField<T, K>is defined asT & Required<Pick<T, K>>.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.