Fix readonly room member action to show Unmute for effectively muted users#39317
Draft
Copilot wants to merge 3 commits into
Draft
Fix readonly room member action to show Unmute for effectively muted users#39317Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix mute/unmute user action in readonly room
Fix readonly room member action to show Unmute for effectively muted users
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In readonly rooms, the member action menu could incorrectly show Mute user even when the target user was already effectively muted by readonly semantics. This change aligns action labeling with actual mute state resolution in readonly rooms.
Readonly mute-state resolution
client/views/room/hooks/useUserInfoActions/actions/getUserIsMuted.tsroom.unmuted.post-readonlynuance when a readonly room has an explicitroom.mutedlist.Hook integration
useMuteUserActionnow consumes the extracted helper so action content (Mute uservsUnmute user) is derived from the corrected state calculation.Targeted coverage
useMuteUserAction.spec.tswith focused cases for:post-readonly+ explicit muted-list behaviorhttps://github.com/user-attachments/assets/71b8680b-a17e-434f-8c43-55423a823967
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fastdl.mongodb.org/home/REDACTED/.npm/_npx/2ad0c2d1aba2dd61/node_modules/node/bin/node /home/REDACTED/.npm/_npx/2ad0c2d1aba2dd61/node_modules/node/bin/node ./postinstall.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.