chore: remove s3 signatureversion setting with migration#39488
chore: remove s3 signatureversion setting with migration#39488ricardogarim wants to merge 3 commits intodevelopfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a59ed34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39488 +/- ##
===========================================
+ Coverage 70.87% 70.91% +0.04%
===========================================
Files 3196 3197 +1
Lines 113288 113327 +39
Branches 20531 20536 +5
===========================================
+ Hits 80294 80368 +74
+ Misses 30943 30913 -30
+ Partials 2051 2046 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
As per CORE-1934, it adds a database migration to remove the deprecated
FileUpload_S3_SignatureVersionsetting from existing installations.This is part of the AWS SDK v3 upgrade (#36659 and #39244). The SDK now handles signature version selection automatically, making this setting unnecessary.
Issue(s)
Steps to test or reproduce
Further comments