fix: third-party login is broken#39523
Open
dionisio-bot[bot] wants to merge 1 commit intorelease-7.13.5from
Open
fix: third-party login is broken#39523dionisio-bot[bot] wants to merge 1 commit intorelease-7.13.5from
dionisio-bot[bot] wants to merge 1 commit intorelease-7.13.5from
Conversation
🦋 Changeset detectedLatest commit: a746ad9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/app/api/server/helpers/parseJsonQuery.ts">
<violation number="1" location="apps/meteor/app/api/server/helpers/parseJsonQuery.ts:31">
P1: Defaulting `queryFields` to `[]` changes behavior and rejects queries on routes that do not define `queryFields`. Keep it `undefined` when absent so the existing validation gate remains correct.</violation>
<violation number="2" location="apps/meteor/app/api/server/helpers/parseJsonQuery.ts:32">
P1: Defaulting `queryOperations` to `[]` disables the intended fallback operator allowlist. Use `undefined` for missing route config so `pathAllowConf.def` is still applied.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| const { userId = '', response, route, logger } = api; | ||
|
|
||
| const params = isPlainObject(api.queryParams) ? api.queryParams : {}; | ||
| const queryFields = Array.isArray(api.queryFields) ? (api.queryFields as string[]) : []; |
Contributor
There was a problem hiding this comment.
P1: Defaulting queryFields to [] changes behavior and rejects queries on routes that do not define queryFields. Keep it undefined when absent so the existing validation gate remains correct.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/api/server/helpers/parseJsonQuery.ts, line 31:
<comment>Defaulting `queryFields` to `[]` changes behavior and rejects queries on routes that do not define `queryFields`. Keep it `undefined` when absent so the existing validation gate remains correct.</comment>
<file context>
@@ -24,10 +25,14 @@ export async function parseJsonQuery(api: PartialThis): Promise<{
+ const { userId = '', response, route, logger } = api;
+
+ const params = isPlainObject(api.queryParams) ? api.queryParams : {};
+ const queryFields = Array.isArray(api.queryFields) ? (api.queryFields as string[]) : [];
+ const queryOperations = Array.isArray(api.queryOperations) ? (api.queryOperations as string[]) : [];
</file context>
Suggested change
| const queryFields = Array.isArray(api.queryFields) ? (api.queryFields as string[]) : []; | |
| const queryFields = Array.isArray(api.queryFields) ? (api.queryFields as string[]) : undefined; |
|
|
||
| const params = isPlainObject(api.queryParams) ? api.queryParams : {}; | ||
| const queryFields = Array.isArray(api.queryFields) ? (api.queryFields as string[]) : []; | ||
| const queryOperations = Array.isArray(api.queryOperations) ? (api.queryOperations as string[]) : []; |
Contributor
There was a problem hiding this comment.
P1: Defaulting queryOperations to [] disables the intended fallback operator allowlist. Use undefined for missing route config so pathAllowConf.def is still applied.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/api/server/helpers/parseJsonQuery.ts, line 32:
<comment>Defaulting `queryOperations` to `[]` disables the intended fallback operator allowlist. Use `undefined` for missing route config so `pathAllowConf.def` is still applied.</comment>
<file context>
@@ -24,10 +25,14 @@ export async function parseJsonQuery(api: PartialThis): Promise<{
+
+ const params = isPlainObject(api.queryParams) ? api.queryParams : {};
+ const queryFields = Array.isArray(api.queryFields) ? (api.queryFields as string[]) : [];
+ const queryOperations = Array.isArray(api.queryOperations) ? (api.queryOperations as string[]) : [];
let sort;
</file context>
Suggested change
| const queryOperations = Array.isArray(api.queryOperations) ? (api.queryOperations as string[]) : []; | |
| const queryOperations = Array.isArray(api.queryOperations) ? (api.queryOperations as string[]) : undefined; |
Contributor
📦 Docker Image Size Report📉 Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/12 22:57", "02/13 22:38", "02/16 14:04", "02/18 23:15", "02/19 23:23", "02/20 22:25", "02/21 04:30", "02/22 19:30", "02/23 23:33", "02/24 23:28", "02/25 22:56", "02/26 23:19", "02/27 23:23", "02/28 01:10", "03/02 21:21", "03/03 23:59", "03/04 23:10", "03/05 21:16", "03/06 22:50", "03/07 05:18", "03/09 20:47", "03/10 19:05", "03/10 20:27 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
line "omnichannel-transcript-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "queue-worker-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
line "rocketchat" [0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.00]
line "stream-hub-service" [0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00]
Statistics (last 30 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Tue, 10 Mar 2026 20:27:50 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37707