chore: convert apis

[ggazzo]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Improved error handling consistency across API endpoints with standardized validation and response schemas
  • Fixed commands.list endpoint response structure when applications are not loaded

• Documentation

  • Added guidelines for API endpoint migration best practices and type augmentation patterns

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is targeting the wrong base branch. It should target 8.4.0, but it targets 8.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: bc60cf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 79f4ac77-0e7f-45ff-a5fe-1c897842d025

📥 Commits

Reviewing files that changed from the base of the PR and between 573e8e7 and bc60cf4.

📒 Files selected for processing (7)

• apps/meteor/app/api/server/v1/chat.ts
• apps/meteor/app/api/server/v1/commands.ts
• apps/meteor/app/api/server/v1/im.ts
• apps/meteor/app/api/server/v1/misc.ts
• apps/meteor/tests/end-to-end/api/commands.ts
• docs/api-endpoint-migration.md
• packages/rest-typings/src/v1/commands.ts

---

Walkthrough

Refactored multiple REST API endpoints to use fluent chainable API pattern with AJV schema validation, replacing legacy API.v1.addRoute() registrations. Updated error responses, removed deprecated type definitions, and added documentation guidelines for endpoint migrations.

Changes

Cohort / File(s)	Summary
API Endpoint Refactoring apps/meteor/app/api/server/v1/chat.ts, apps/meteor/app/api/server/v1/commands.ts, apps/meteor/app/api/server/v1/im.ts, apps/meteor/app/api/server/v1/misc.ts	Migrated endpoints from legacy API.v1.addRoute() to fluent chainable pattern with explicit AJV schemas for query/body/response validation. Updated error responses and standardized 200/400/401/403 status handling. Key changes include: chat.react and chat.reportMessage with action handlers, commands.list with paginated response schema, consolidated dm/im endpoints with typed validation, and shield.svg with structured response object.
Type Definitions packages/rest-typings/src/v1/commands.ts	Removed exported endpoint type declaration for /v1/commands.list including related type imports for SlashCommand, PaginatedRequest, and PaginatedResult.
Test Updates apps/meteor/tests/end-to-end/api/commands.ts	Updated authorization failure assertion for commands.run to expect 'unauthorized' error instead of 'Not allowed'.
Documentation docs/api-endpoint-migration.md	Added migration guidelines clarifying augmentation scope limited to apps/meteor, type definition retention requirements, and as const usage for endpoint option objects to preserve literal type inference.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested labels

type: chore

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.57%. Comparing base (573e8e7) to head (bc60cf4).
⚠️ Report is 13 commits behind head on chore/apis.

Additional details and impacted files

@@              Coverage Diff               @@
##           chore/apis   #39779      +/-   ##
==============================================
+ Coverage       70.55%   70.57%   +0.01%     
==============================================
  Files            3256     3256              
  Lines          115791   115791              
  Branches        21083    21015      -68     
==============================================
+ Hits            81694    81715      +21     
+ Misses          32023    32011      -12     
+ Partials         2074     2065       -9     

Flag	Coverage Δ
e2e	60.44% <ø> (+0.03%)	⬆️
e2e-api	49.06% <ø> (+0.96%)	⬆️
unit	71.07% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cubic-dev-ai]

2 issues found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/app/api/server/v1/im.ts">

<violation number="1" location="apps/meteor/app/api/server/v1/im.ts:313">
P2: `dm.setTopic` can return `topic: null` even though its response schema only permits string values.</violation>

<violation number="2" location="apps/meteor/app/api/server/v1/im.ts:752">
P3: `dm.create` and `im.create` now duplicate the same endpoint config and handler; extract one shared action/config to avoid divergence.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: dm.setTopic can return topic: null even though its response schema only permits string values.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/api/server/v1/im.ts, line 313:

<comment>`dm.setTopic` can return `topic: null` even though its response schema only permits string values.</comment>

<file context>
@@ -240,296 +219,597 @@ const dmCloseAction = <Path extends string>(_path: Path): TypedAction<typeof dmC
-				projection: fields,
-			});
+		return API.v1.success({
+			topic,
+		});
+	};
</file context>

Suggested change

	topic,
	topic: topic ?? '',

[cubic-dev-ai]

P3: dm.create and im.create now duplicate the same endpoint config and handler; extract one shared action/config to avoid divergence.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/api/server/v1/im.ts, line 752:

<comment>`dm.create` and `im.create` now duplicate the same endpoint config and handler; extract one shared action/config to avoid divergence.</comment>

<file context>
@@ -240,296 +219,597 @@ const dmCloseAction = <Path extends string>(_path: Path): TypedAction<typeof dmC
+	.post('dm.close', dmCloseEndpointsProps, dmCloseAction('dm.close'))
+	.post('im.close', dmCloseEndpointsProps, dmCloseAction('im.close'))
+	.post(
+		'dm.create',
+		{
+			authRequired: true,
</file context>