refactor(groups): Migrated groups.invites to typed REST endpoint#39867
refactor(groups): Migrated groups.invites to typed REST endpoint#39867Harxhit wants to merge 2 commits intoRocketChat:developfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: ea12207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/app/api/server/v1/groups.ts">
<violation number="1" location="apps/meteor/app/api/server/v1/groups.ts:58">
P2: AJV schema for groups.invite omits legacy username/user fields that getUserListFromParams still accepts, so existing clients sending those fields will now fail validation.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Proposed changes
Refactors the groups.invite endpoint to use the typed REST API endpoint system used by other API routes.
The endpoint now includes:
userId,userIds,usernames)Issue(s)
N/A
Further comments
This migration aligns the groups.invite endpoint with the typed REST API route pattern used across the codebase.
The request schema was expanded to reflect the actual runtime behavior of the endpoint, which supports inviting users via multiple input formats (
userId,userIds, orusernames).No functional changes were introduced. Only structure, validation, and documentation improvements were made.
There were no available TestAPI cases for this endpoint, so no additional proof of testing has been attached.
Swagger UI Proof
Schema
200
400