test: improve coverage for useRoomToolboxActions

[dev-x-Aryan]

This PR improves unit test coverage for the useRoomToolboxActions hook by adding edge case tests.

The added tests cover:

• behavior when the toolbox is collapsed (no visible actions)
• boundary condition when exactly 6 actions exist
• filtering of disabled actions from hiddenActions

These additions improve reliability and ensure correct behavior of action distribution logic in the room header.

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for room toolbox actions to validate proper behavior under different layout states and action configurations.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 167ea41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

This pull request adds unit test coverage for the useRoomToolboxActions hook, validating behavior across different room toolbox expanded states and action configurations. The change is entirely test-focused with no modifications to existing tests.

Changes

Cohort / File(s)	Summary
Test Coverage apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts	Added three new unit tests: validating empty visibleActions when roomToolboxExpanded is false, confirming all 6 actions appear when roomToolboxExpanded is true at boundary case, and verifying disabled actions are excluded from hiddenActions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'test: improve coverage for useRoomToolboxActions' directly and accurately describes the main change: adding unit tests to improve coverage for the useRoomToolboxActions hook.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file

[coderabbitai]

🧹 Nitpick comments (1)

apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts (1)

73-86: Test correctly validates disabled action filtering.

The test properly verifies that disabled actions are excluded from hiddenActions according to the hook's filtering logic.

Consider enhancing test coverage by also verifying that enabled, non-featured actions DO appear in hiddenActions when roomToolboxExpanded is false (the current test only checks the exclusion case). However, this is optional since the current test name and scope are clear.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts`
around lines 73 - 86, Add an additional spec to verify that enabled,
non-featured actions are included in hiddenActions when the toolbox is
collapsed: render the useRoomToolboxActions hook with an enabled action (based
on the existing actions array), use mockAppRoot().withLayout({
roomToolboxExpanded: false }).build(), then assert result.current.hiddenActions
contains that action (e.g., length === 1 and matches the action). Reference the
hook useRoomToolboxActions, the hiddenActions result field, and the
mockAppRoot/.withLayout setup when adding the new test.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts`:
- Around line 73-86: Add an additional spec to verify that enabled, non-featured
actions are included in hiddenActions when the toolbox is collapsed: render the
useRoomToolboxActions hook with an enabled action (based on the existing actions
array), use mockAppRoot().withLayout({ roomToolboxExpanded: false }).build(),
then assert result.current.hiddenActions contains that action (e.g., length ===
1 and matches the action). Reference the hook useRoomToolboxActions, the
hiddenActions result field, and the mockAppRoot/.withLayout setup when adding
the new test.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f564f4d1-07c7-4bb4-85a1-916f2f38e861

📥 Commits

Reviewing files that changed from the base of the PR and between 4235cd9 and 167ea41.

📒 Files selected for processing (1)

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📜 Review details

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

**/*.spec.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use .spec.ts extension for test files (e.g., login.spec.ts)

Files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

🧠 Learnings (11)

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Utilize Playwright fixtures (`test`, `page`, `expect`) for consistency in test files

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `expect` matchers for assertions (`toEqual`, `toContain`, `toBeTruthy`, `toHaveLength`, etc.) instead of `assert` statements in Playwright tests

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure tests run reliably in parallel without shared state conflicts

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2025-12-10T21:00:54.909Z

Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:54.909Z
Learning: Rocket.Chat monorepo: Jest testMatch pattern '<rootDir>/src/**/*.spec.(ts|js|mjs)' is valid in this repo and used across multiple packages (e.g., packages/tools, ee/packages/omnichannel-services). Do not flag it as invalid in future reviews.

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Prefer web-first assertions (`toBeVisible`, `toHaveText`, etc.) in Playwright tests

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2026-02-24T19:36:55.089Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/page-objects/fragments/home-content.ts:60-82
Timestamp: 2026-02-24T19:36:55.089Z
Learning: In RocketChat/Rocket.Chat e2e tests (apps/meteor/tests/e2e/page-objects/fragments/home-content.ts), thread message preview listitems do not have aria-roledescription="message", so lastThreadMessagePreview locator cannot be scoped to messageListItems (which filters for aria-roledescription="message"). It should remain scoped to page.getByRole('listitem') or mainMessageList.getByRole('listitem').

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2026-02-10T16:32:42.586Z

Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38528
File: apps/meteor/client/startup/roles.ts:14-14
Timestamp: 2026-02-10T16:32:42.586Z
Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON and Date fields arrive as Date objects; do not manually construct new Date() in stream handlers (for example, in sdk.stream()). Only REST API responses return plain JSON where dates are strings, so implement explicit conversion there if needed. Apply this guidance to all TypeScript files under apps/meteor/client to ensure consistent date handling in DDP streams and REST responses.

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2026-02-24T19:22:48.358Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

📚 Learning: 2026-03-06T18:10:15.268Z

Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.

Applied to files:

• apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts

🔇 Additional comments (2)

apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts (2)

44-55: LGTM! Validates collapsed toolbox behavior.

The test correctly verifies that when the room toolbox is collapsed (roomToolboxExpanded: false), visibleActions returns an empty array, matching the implementation logic.

---

57-71: Boundary condition test is correct.

The test properly validates that when exactly 6 non-featured actions exist and the toolbox is expanded, all actions appear in visibleActions with no overflow into hiddenActions. The logic correctly removes the featured flag to ensure actions are treated as normal actions.