chore(message-parser): remove stale team collaboration styling from quote attachments#39921
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughRemoved a legacy CSS-in-JS block and unused imports from the QuoteAttachment component; the component no longer passes a custom Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes legacy, locally-scoped styling overrides from the QuoteAttachment component so it falls back to standard @rocket.chat/fuselage attachment styling.
Changes:
- Removed obsolete CSS-in-JS
quoteStylesblock (and related imports). - Dropped
className={quoteStyles}from<AttachmentContent>, restoring default styling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
There was a problem hiding this comment.
There are multiple consecutive blank lines left after removing quoteStyles. Consider collapsing to a single blank line to keep formatting consistent with other attachment components in this directory.
Proposed changes
Removes stale technical debt from
QuoteAttachmentcomponent by stripping obsolete CSS-in-JS overrides.Root Cause / Problem
An obsolete CSS-in-JS block was manually overriding standard Fuselage styling with custom hover states and borders. This was tracked by a continuous
// TODO: remove this team collaborationcomment.Solution / Behavior
Deleted the legacy quoteStyles block entirely and removed the className prop, restoring the component to standard, globally maintained @rocket.chat/fuselage aesthetics.
Issue(s)
Closes #39920
Validation & Testing
Tested locally (UI components render correctly without style conflicts)
Extracted dead imports (no TS compiler warnings)
Preserved existing components (no runtime behavior changed)
Type of change
chore: small task (technical debt removal)
Summary by CodeRabbit