Skip to content

chore(message-parser): remove stale team collaboration styling from quote attachments#39921

Open
thekishandev wants to merge 2 commits into
RocketChat:developfrom
thekishandev:chore/remove-team-collaboration-styling-39920
Open

chore(message-parser): remove stale team collaboration styling from quote attachments#39921
thekishandev wants to merge 2 commits into
RocketChat:developfrom
thekishandev:chore/remove-team-collaboration-styling-39920

Conversation

@thekishandev
Copy link
Copy Markdown

@thekishandev thekishandev commented Mar 28, 2026

Proposed changes

Removes stale technical debt from QuoteAttachment component by stripping obsolete CSS-in-JS overrides.

Root Cause / Problem

An obsolete CSS-in-JS block was manually overriding standard Fuselage styling with custom hover states and borders. This was tracked by a continuous // TODO: remove this team collaboration comment.

// BEFORE
// TODO: remove this team collaboration
const quoteStyles = css`
	.rcx-attachment__details {
		.rcx-message-body {
			color: ${Palette.text['font-default']};
		}
<AttachmentContent className={quoteStyles} width='full'>

Solution / Behavior
Deleted the legacy quoteStyles block entirely and removed the className prop, restoring the component to standard, globally maintained @rocket.chat/fuselage aesthetics.

// AFTER
<AttachmentContent width='full'>

Issue(s)
Closes #39920

Validation & Testing
Tested locally (UI components render correctly without style conflicts)
Extracted dead imports (no TS compiler warnings)
Preserved existing components (no runtime behavior changed)

Type of change
chore: small task (technical debt removal)

Summary by CodeRabbit

  • Refactor
    • Simplified quote attachment styling by removing custom quote-specific style overrides. Quote content now uses the app’s default attachment styles and standard hover/focus behaviors instead of bespoke class-based adjustments.

@thekishandev thekishandev requested a review from a team as a code owner March 28, 2026 11:22
Copilot AI review requested due to automatic review settings March 28, 2026 11:22
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Mar 28, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 28, 2026

⚠️ No Changeset found

Latest commit: d60b4f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 90de2dbd-7352-4d18-b59f-82525408a813

📥 Commits

Reviewing files that changed from the base of the PR and between 37c2181 and d60b4f8.

📒 Files selected for processing (1)
  • apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx
✅ Files skipped from review due to trivial changes (1)
  • apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx

Walkthrough

Removed a legacy CSS-in-JS block and unused imports from the QuoteAttachment component; the component no longer passes a custom className to AttachmentContent, reverting to the standard Fuselage styling.

Changes

Cohort / File(s) Summary
Quote Attachment Styling Cleanup
apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx
Deleted quoteStyles CSS-in-JS block, removed css and Palette imports, and removed className={quoteStyles} from <AttachmentContent> so it uses default Fuselage styles.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of stale CSS styling from quote attachments in the message component.
Linked Issues check ✅ Passed The PR fully addresses both coding objectives: deletes the quoteStyles CSS block and removes the className prop from AttachmentContent as required by issue #39920.
Out of Scope Changes check ✅ Passed All changes directly address the linked issue requirements with no extraneous modifications beyond the scope of removing legacy styling overrides.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy, locally-scoped styling overrides from the QuoteAttachment component so it falls back to standard @rocket.chat/fuselage attachment styling.

Changes:

  • Removed obsolete CSS-in-JS quoteStyles block (and related imports).
  • Dropped className={quoteStyles} from <AttachmentContent>, restoring default styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 16 to 17


Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple consecutive blank lines left after removing quoteStyles. Consider collapsing to a single blank line to keep formatting consistent with other attachment components in this directory.

Suggested change

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(message-parser): remove stale team collaboration styling from quote attachments

2 participants