fix: Review fixes

[KevLehman]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Bug Fixes

  • Enhanced validation for ABAC Virtru synchronization interval configuration to prevent invalid cron expressions.
  • Improved health response schema validation to ensure proper data structure.
  • Fixed configuration watcher to properly respond to all relevant settings changes.

• Performance

  • Optimized PDP health checks with intelligent result caching.
  • Added configurable cache TTL settings for authorization service performance tuning.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: ba8c6b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5f184fdc-7ac7-4087-b778-dd83fd9f471a

📥 Commits

Reviewing files that changed from the base of the PR and between 39b3792 and ba8c6b2.

📒 Files selected for processing (5)

• apps/meteor/ee/server/api/abac/schemas.ts
• apps/meteor/ee/server/configuration/abac.ts
• docker-compose-ci.yml
• ee/packages/abac/src/index.ts
• ee/packages/abac/src/pdp/VirtruPDP.ts

---

Walkthrough

Updates to the ABAC (Attribute-Based Access Control) system include schema validation for health responses, runtime validation of cron intervals, URL normalization utilities, memoization-based caching of health checks, and cache TTL configuration. Changes span validation, configuration, and performance layers.

Changes

Cohort / File(s)	Summary
Health Check Validation & Caching apps/meteor/ee/server/api/abac/schemas.ts, ee/packages/abac/src/pdp/VirtruPDP.ts, docker-compose-ci.yml	Updated JSON schemas to require the success property in PDP health responses; implemented mem-based memoization for health checks with configurable TTL via ABAC_HEALTH_CACHE_TTL_MS (default 5 minutes); added environment variable to CI configuration.
Configuration Handling & Validation apps/meteor/ee/server/configuration/abac.ts, ee/packages/abac/src/index.ts	Added runtime cron validation for ABAC_Virtru_Sync_Interval to prevent invalid job scheduling; updated watcher to trigger on ABAC_Enabled changes; introduced stripTrailingSlashes helper to normalize URL configuration values across three call sites.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

type: bug, area: authentication

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.39%. Comparing base (39b3792) to head (ba8c6b2).
⚠️ Report is 1 commits behind head on feat/externalpdp.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feat/externalpdp   #40065      +/-   ##
====================================================
+ Coverage             70.37%   70.39%   +0.01%     
====================================================
  Files                  3271     3270       -1     
  Lines                117080   117082       +2     
  Branches              21113    21126      +13     
====================================================
+ Hits                  82399    82422      +23     
+ Misses                32617    32590      -27     
- Partials               2064     2070       +6     

Flag	Coverage Δ
e2e	60.49% <ø> (-0.01%)	⬇️
e2e-api	49.07% <ø> (+0.97%)	⬆️
unit	70.74% <62.50%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.