Skip to content

chore: remove outdated oplog error message from admin workspace page#40066

Merged
dionisio-bot[bot] merged 5 commits intodevelopfrom
chore/remove-outdated-oplog-error
Apr 9, 2026
Merged

chore: remove outdated oplog error message from admin workspace page#40066
dionisio-bot[bot] merged 5 commits intodevelopfrom
chore/remove-outdated-oplog-error

Conversation

@abhinavkrin
Copy link
Copy Markdown
Member

@abhinavkrin abhinavkrin commented Apr 7, 2026

Proposed changes (including videos or screenshots)

This PR removes an outdated error message from the admin workspace page that referenced oplog requirements for multiple instances. Since oplog is no longer required, this message is no longer relevant and has been cleaned up for a better admin experience.

Issue(s)

Steps to test or reproduce

Further comments

CORE-1869

Summary by CodeRabbit

  • Chores
    • Removed oplog-related warning and accompanying error/configuration messaging from the workspace admin view.
    • Removed oplog-related status suffix from MongoDB info in the deployment summary.
    • Deleted the corresponding error message translations across all supported locales.

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
…ple_instances from translations

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin requested a review from a team as a code owner April 7, 2026 16:30
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Apr 7, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 7, 2026

⚠️ No Changeset found

Latest commit: f578c35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@abhinavkrin abhinavkrin changed the title Chore/remove outdated oplog error chore: remove outdated oplog error message from admin workspace page Apr 7, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a53ef70-3b8f-455a-807c-f188ed77f113

📥 Commits

Reviewing files that changed from the base of the PR and between 1defc16 and f578c35.

📒 Files selected for processing (3)
  • packages/i18n/src/locales/en.i18n.json
  • packages/i18n/src/locales/nb.i18n.json
  • packages/i18n/src/locales/zh.i18n.json
💤 Files with no reviewable changes (3)
  • packages/i18n/src/locales/en.i18n.json
  • packages/i18n/src/locales/nb.i18n.json
  • packages/i18n/src/locales/zh.i18n.json
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: 🔨 Test Storybook / Test Storybook
  • GitHub Check: 🔎 Code Check / Code Lint
  • GitHub Check: 🔎 Code Check / TypeScript
  • GitHub Check: 🔨 Test Unit / Unit Tests
  • GitHub Check: 📦 Meteor Build (coverage)
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build

Walkthrough

Removed oplog-related warning UI and i18n keys across the admin workspace; also removed the oplog-status suffix from the DeploymentCard MongoDB display.

Changes

Cohort / File(s) Summary
Admin UI — Workspace page
apps/meteor/client/views/admin/workspace/WorkspacePage.tsx
Deleted computed alertOplogForMultipleInstances and the danger Callout/UI that warned about oplog tailing for multiple non-enterprise monolith instances.
Admin UI — Deployment card
apps/meteor/client/views/admin/workspace/DeploymentCard/DeploymentCard.tsx
Removed conditional oplog-status suffix from MongoDB display; now renders only statistics.mongoVersion / statistics.mongoStorageEngine.
Internationalization
packages/i18n/src/locales/*, packages/i18n/src/locales/.../*.i18n.json
Removed two i18n keys from all locale JSONs: Error_RocketChat_requires_oplog_tailing_when_running_in_multiple_instances and Error_RocketChat_requires_oplog_tailing_when_running_in_multiple_instances_details.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing an outdated oplog error message from the admin workspace page, which aligns with the PR's primary objective.
Linked Issues check ✅ Passed The PR successfully addresses CORE-1869 by removing all oplog-related validation messaging from the UI (WorkspacePage component) and translation files across all supported languages.
Out of Scope Changes check ✅ Passed All changes are directly related to removing oplog error messages and their translations as required by CORE-1869. The removal of oplog status indicator in DeploymentCard is a closely related cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 53 files

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.56%. Comparing base (f21ed3a) to head (f578c35).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40066      +/-   ##
===========================================
- Coverage    70.59%   70.56%   -0.03%     
===========================================
  Files         3273     3273              
  Lines       116880   116877       -3     
  Branches     21110    21088      -22     
===========================================
- Hits         82512    82475      -37     
- Misses       32309    32356      +47     
+ Partials      2059     2046      -13     
Flag Coverage Δ
e2e 60.64% <ø> (-0.10%) ⬇️
e2e-api 48.14% <ø> (-0.98%) ⬇️
unit 70.99% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris added this to the 8.4.0 milestone Apr 8, 2026
@abhinavkrin abhinavkrin requested a review from a team as a code owner April 8, 2026 17:00
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin force-pushed the chore/remove-outdated-oplog-error branch from 4e079b4 to 1defc16 Compare April 8, 2026 17:02
@KevLehman
Copy link
Copy Markdown
Member

A note: there's generally no need to remove the translations from all languages. Removing the english one is enough as lingohub would remove it from the other languages on the next update.

@dougfabris dougfabris removed the request for review from a team April 8, 2026 18:00
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Apr 8, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 8, 2026
@dionisio-bot dionisio-bot Bot enabled auto-merge April 8, 2026 18:01
@dionisio-bot dionisio-bot Bot added this pull request to the merge queue Apr 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 8, 2026
@dougfabris dougfabris removed the stat: QA assured Means it has been tested and approved by a company insider label Apr 9, 2026
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 9, 2026
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Apr 9, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 9, 2026
@dionisio-bot dionisio-bot Bot added this pull request to the merge queue Apr 9, 2026
Merged via the queue into develop with commit 93e3193 Apr 9, 2026
46 checks passed
@dionisio-bot dionisio-bot Bot deleted the chore/remove-outdated-oplog-error branch April 9, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants