Skip to content

chore: Update mockserver image to RocketChat org#40205

Merged
dionisio-bot[bot] merged 1 commit into
developfrom
chore/update-mockserver-image
Apr 17, 2026
Merged

chore: Update mockserver image to RocketChat org#40205
dionisio-bot[bot] merged 1 commit into
developfrom
chore/update-mockserver-image

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Apr 17, 2026

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/PRD-329

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Updated mock-server container image to a specific pinned version for improved consistency and reliability in CI environments.
    • Updated YAML configuration formatting in docker-compose file.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Apr 17, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2026

⚠️ No Changeset found

Latest commit: c4c43ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2503789f-45d6-42f3-b6c6-189c3c0c4158

📥 Commits

Reviewing files that changed from the base of the PR and between 7d19209 and c4c43ad.

📒 Files selected for processing (1)
  • docker-compose-ci.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: cubic · AI code reviewer
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: smirk-dev
Repo: RocketChat/Rocket.Chat PR: 39625
File: apps/meteor/app/api/server/v1/push.ts:85-97
Timestamp: 2026-03-14T14:58:58.834Z
Learning: In RocketChat/Rocket.Chat, the `push.token` POST/DELETE endpoints in `apps/meteor/app/api/server/v1/push.ts` were already migrated to the chained router API pattern on `develop` prior to PR `#39625`. `cleanTokenResult` (which strips `authToken` and returns `PushTokenResult`) and `isPushTokenPOSTProps`/`isPushTokenDELETEProps` validators already exist on `develop`. PR `#39625` only migrates `push.get` and `push.info` to the chained pattern. Do not flag `cleanTokenResult` or `PushTokenResult` as newly introduced behavior-breaking changes when reviewing this PR.
Learnt from: ggazzo
Repo: RocketChat/Rocket.Chat PR: 35995
File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112
Timestamp: 2026-02-23T17:53:18.785Z
Learning: In Rocket.Chat PR reviews, maintain strict scope boundaries—when a PR is focused on a specific endpoint (e.g., rooms.favorite), avoid reviewing or suggesting changes to other endpoints that were incidentally refactored (e.g., rooms.invite) unless explicitly requested by maintainers.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
🔇 Additional comments (1)
docker-compose-ci.yml (1)

203-213: LGTM!

Switching to the org-scoped ghcr.io/rocketchat/mockserver image and pinning by SHA256 digest aligns with the PR objective (PRD-329) and yields an immutable, reproducible pull. CI workflows already authenticate to ghcr.io (see .github/workflows/ci-test-e2e.yml and .github/workflows/ci.yml), so image access is covered. The healthcheck quote-style change is cosmetically equivalent YAML with no behavioral impact.


Walkthrough

Updated the mock-server service container image in docker-compose-ci.yml from a personal repository tag to a Rocket.Chat-hosted image pinned by SHA256 digest. Also adjusted the healthcheck test command formatting from double-quoted to single-quoted YAML list syntax.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker-compose-ci.yml
Updated mock-server image reference from kaleman14/mockserver:latest to ghcr.io/rocketchat/mockserver@sha256:... for organizational image management. Changed healthcheck test array syntax from double-quoted to single-quoted list representation without altering functionality.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating the mockserver image to use the RocketChat organization.
Linked Issues check ✅ Passed The code changes meet the requirement from PRD-329 by replacing the personal kaleman14/mockserver image with the RocketChat-scoped ghcr.io/rocketchat/mockserver image.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of replacing the personal Docker image with the RocketChat-scoped image; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.04%. Comparing base (7d19209) to head (c4c43ad).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40205      +/-   ##
===========================================
- Coverage    70.07%   70.04%   -0.03%     
===========================================
  Files         3289     3289              
  Lines       117541   117541              
  Branches     20844    20846       +2     
===========================================
- Hits         82361    82335      -26     
- Misses       31890    31900      +10     
- Partials      3290     3306      +16     
Flag Coverage Δ
e2e 59.66% <ø> (-0.05%) ⬇️
e2e-api 46.20% <ø> (-0.06%) ⬇️
unit 70.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman added this to the 8.4.0 milestone Apr 17, 2026
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Apr 17, 2026
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Apr 17, 2026
@KevLehman KevLehman marked this pull request as ready for review April 17, 2026 18:19
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@dionisio-bot dionisio-bot Bot added this pull request to the merge queue Apr 17, 2026
Merged via the queue into develop with commit 25527a6 Apr 17, 2026
48 checks passed
@dionisio-bot dionisio-bot Bot deleted the chore/update-mockserver-image branch April 17, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants