Conversation
- @react-pdf/renderer 4.3.2 -> 4.3.3 (pinned with ~ to stay patch-level) - @xmldom/xmldom 0.8.12 -> 0.8.13 - @swc/core 1.15.26 -> 1.15.30 - dompurify 3.4.0 -> 3.4.1 - html-webpack-plugin 5.6.6 -> 5.6.7 - jsrsasign 11.1.2 -> 11.1.3 - vite 8.0.8 -> 8.0.9 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Looks like this PR is ready to merge! 🎉 |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
WalkthroughBumped dependency versions across multiple package.json files: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tassoevan
left a comment
There was a problem hiding this comment.
Apart from @react-pdf/renderer (which uses a patched package, @react-pdf/layout) everything seems safe to upgrade.
|
/jira ARCH-2083 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #40261 +/- ##
===========================================
- Coverage 69.82% 69.81% -0.02%
===========================================
Files 3296 3296
Lines 119173 119173
Branches 21453 21471 +18
===========================================
- Hits 83215 83197 -18
- Misses 32666 32674 +8
- Partials 3292 3302 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Upgrading @react-pdf/renderer 4.3.2 -> 4.3.3 pulls @react-pdf/font 4.0.8
through a `^4.0.5` range, which then requires @react-pdf/pdfkit ^5.1.1
(a major jump from 4.1.0). That 5.x pdfkit depends on `js-md5`, which
the Meteor server bundle cannot resolve at runtime:
Error: Cannot find module 'js-md5'
Require stack:
- @react-pdf/pdfkit/lib/pdfkit.js
- @react-pdf/font/lib/index.js
- @react-pdf/renderer/lib/react-pdf.js
Reverting to ^4.3.2 keeps font 4.0.4 and pdfkit 4.1.0, which build OK.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
~X.Y.Zfor@react-pdf/rendererto prevent the^minor-jump issue that affected react-virtuoso in the previous PRBumps
@react-pdf/renderer4.3.2 → 4.3.3 (pinned with~to stay patch-level)@xmldom/xmldom0.8.12 → 0.8.13@swc/core1.15.26 → 1.15.30dompurify3.4.0 → 3.4.1html-webpack-plugin5.6.6 → 5.6.7jsrsasign11.1.2 → 11.1.3vite8.0.8 → 8.0.9Deliberately skipped
Known breaking patches from prior investigation in #40172:
@noble/ed255193.0.0 → 3.0.1 — broke E2EE (new negative-coordinate validation)cron1.8.2 → 1.8.3 — migrated moment-timezone → luxon internallyhono4.12.5 → 4.12.14 — cookie/CORS behavioral changesPre-release bumps skipped:
@react-aria/toolbarnightly@react-spectrum/test-utilsalpha → betaTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Task: ARCH-2110