chore: Upgrade fuselage packages#40328
Merged
juliajforesti merged 10 commits intodevelopfrom Apr 29, 2026
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (5)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
🧠 Learnings (3)📓 Common learnings📚 Learning: 2026-04-10T22:42:05.539ZApplied to files:
📚 Learning: 2026-03-27T14:52:56.865ZApplied to files:
🔇 Additional comments (1)
WalkthroughUpdates Rocket.Chat UI package version ranges across the monorepo and modifies Playwright e2e test selectors and page-object locators (combobox/label/aria-based selectors and direct input clicks) and a few image/object-fit prop usages in UI components. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
|
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
juliajforesti
force-pushed
the
chore/bump-fuselage
branch
from
4459ff5 to
f670e91
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40328 +/- ##
===========================================
- Coverage 69.87% 69.85% -0.02%
===========================================
Files 3296 3297 +1
Lines 119186 119267 +81
Branches 21525 21530 +5
===========================================
+ Hits 83285 83319 +34
- Misses 32613 32646 +33
- Partials 3288 3302 +14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts (2)
59-63: Avoid duplicating member-invite flow ininviteUserToChannel.
CreateNewChannelModal.inviteUserToChannelcan delegate toCreateNewModal.addMemberto keep one source of truth for the interaction sequence.Based on learnings: Applies to `apps/meteor/tests/e2e/page-objects/**/*.ts` — utilize existing page objects pattern from `apps/meteor/tests/e2e/page-objects/`.♻️ Proposed refactor
async inviteUserToChannel(username: string) { - await this.inputAddMembers.click(); - await this.inputAddMembers.fill(username); - await this.listbox.selectOption(username); + await this.addMember(username); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts` around lines 59 - 63, The inviteUserToChannel implementation duplicates the member-invite steps; change it to call the existing CreateNewModal.addMember(username) so there is a single source of truth for the interaction sequence—replace the body of inviteUserToChannel to delegate to CreateNewModal.addMember and remove the duplicated clicks/fills/selects, ensuring any awaited behavior and return values match the addMember method's contract.
46-46: ReuseinputAddMembersat Line 46 instead of re-querying the same locator.This avoids drift if the locator contract changes again.
As per coding guidelines, `apps/meteor/tests/e2e/**/*.{ts,spec.ts}` should store commonly used locators in variables/constants for reuse.♻️ Proposed refactor
- await this.root.getByRole('combobox', { name: 'Members' }).click(); + await this.inputAddMembers.click();🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts` at line 46, The locator for the Members combobox is being re-queried at Line 46 using this.root.getByRole('combobox', { name: 'Members' }) instead of reusing the already-defined locator variable inputAddMembers; replace the direct getByRole call with the stored locator (inputAddMembers.click()) so future locator changes only need one update—update any other occurrences in the same file that re-query this combobox to reuse inputAddMembers as well.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts`:
- Around line 59-63: The inviteUserToChannel implementation duplicates the
member-invite steps; change it to call the existing
CreateNewModal.addMember(username) so there is a single source of truth for the
interaction sequence—replace the body of inviteUserToChannel to delegate to
CreateNewModal.addMember and remove the duplicated clicks/fills/selects,
ensuring any awaited behavior and return values match the addMember method's
contract.
- Line 46: The locator for the Members combobox is being re-queried at Line 46
using this.root.getByRole('combobox', { name: 'Members' }) instead of reusing
the already-defined locator variable inputAddMembers; replace the direct
getByRole call with the stored locator (inputAddMembers.click()) so future
locator changes only need one update—update any other occurrences in the same
file that re-query this combobox to reuse inputAddMembers as well.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bd4c50a2-8cb5-45f8-a9ef-e595e4e758e8
⛔ Files ignored due to path filters (10)
apps/meteor/client/components/CreateDiscussion/__snapshots__/CreateDiscussion.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/components/message/toolbar/items/actions/Timestamp/TimestampPicker/__snapshots__/TimestampPicker.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/views/admin/ABAC/ABACRoomsTab/__snapshots__/RoomFormAttributeField.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/Filters/__snapshots__/AppLogsFilterContextualBar.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/Filters/__snapshots__/AppLogsFilterExpanded.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/__snapshots__/CannedResponseList.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/views/room/contextualBar/RoomFiles/__snapshots__/RoomFiles.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/__snapshots__/InviteUsers.spec.tsx.snapis excluded by!**/*.snapapps/meteor/client/views/room/contextualBar/RoomMembers/__snapshots__/RoomMembers.spec.tsx.snapis excluded by!**/*.snapyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (18)
apps/meteor/package.jsonapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.tsapps/uikit-playground/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/package.jsonpackages/storybook-config/package.jsonpackages/ui-avatar/package.jsonpackages/ui-client/package.jsonpackages/ui-client/src/components/CustomFieldsForm.spec.tsxpackages/ui-composer/package.jsonpackages/ui-contexts/package.jsonpackages/ui-video-conf/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.json
📜 Review details
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
apps/meteor/tests/e2e/page-objects/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Utilize existing page objects pattern from
apps/meteor/tests/e2e/page-objects/
Files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
apps/meteor/tests/e2e/**/*.{ts,spec.ts}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
apps/meteor/tests/e2e/**/*.{ts,spec.ts}: Store commonly used locators in variables/constants for reuse
Follow Page Object Model pattern consistently in Playwright tests
Files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use.spec.tsextension for test files (e.g.,login.spec.ts)
Files:
apps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
apps/meteor/tests/e2e/**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
apps/meteor/tests/e2e/**/*.spec.ts: All test files must be created inapps/meteor/tests/e2e/directory
Avoid usingpage.locator()in Playwright tests - always prefer semantic locators such aspage.getByRole(),page.getByLabel(),page.getByText(), orpage.getByTitle()
Usetest.beforeAll()andtest.afterAll()for setup/teardown in Playwright tests
Usetest.step()for complex test scenarios to improve organization in Playwright tests
Group related tests in the same file
Utilize Playwright fixtures (test,page,expect) for consistency in test files
Prefer web-first assertions (toBeVisible,toHaveText, etc.) in Playwright tests
Useexpectmatchers for assertions (toEqual,toContain,toBeTruthy,toHaveLength, etc.) instead ofassertstatements in Playwright tests
Usepage.waitFor()with specific conditions instead of hardcoded timeouts in Playwright tests
Implement proper wait strategies for dynamic content in Playwright tests
Maintain test isolation between test cases in Playwright tests
Ensure clean state for each test execution in Playwright tests
Ensure tests run reliably in parallel without shared state conflicts
Files:
apps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
🧠 Learnings (40)
📓 Common learnings
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: In Rocket.Chat PRs, keep feature PRs free of unrelated lockfile-only dependency bumps; prefer reverting lockfile drift or isolating such bumps into a separate "chore" commit/PR, and always use yarn install --immutable with the Yarn version pinned in package.json via Corepack.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:23.330Z
Learning: In the RocketChat/Rocket.Chat `packages/gazzodown` package and more broadly, the HTML `<code>` element has an implicit ARIA role of `code` per WAI-ARIA 1.3, and `testing-library/dom` / jsdom supports it. Therefore, `screen.getByRole('code')` / `screen.findByRole('code')` correctly locates `<code>` elements without needing an explicit `role="code"` attribute. Do NOT flag `findByRole('code')` as invalid in future reviews.
Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:54.909Z
Learning: Rocket.Chat monorepo: Jest testMatch pattern '<rootDir>/src/**/*.spec.(ts|js|mjs)' is valid in this repo and used across multiple packages (e.g., packages/tools, ee/packages/omnichannel-services). Do not flag it as invalid in future reviews.
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/page-objects/fragments/home-content.ts:60-82
Timestamp: 2026-02-24T19:36:55.089Z
Learning: In RocketChat/Rocket.Chat e2e tests (apps/meteor/tests/e2e/page-objects/fragments/home-content.ts), thread message preview listitems do not have aria-roledescription="message", so lastThreadMessagePreview locator cannot be scoped to messageListItems (which filters for aria-roledescription="message"). It should remain scoped to page.getByRole('listitem') or mainMessageList.getByRole('listitem').
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:52.984Z
Learning: In RocketChat/Rocket.Chat Playwright e2e tests, prefer using translated text and ARIA roles (getByRole, getByText, etc.) over data-qa locators. If translation values change, update the corresponding test locators accordingly. Never prefer data-qa locators.
Learnt from: cardoso
Repo: RocketChat/Rocket.Chat PR: 39690
File: packages/ui-voip/package.json:11-11
Timestamp: 2026-03-17T16:08:37.572Z
Learning: In `packages/ui-voip/package.json` (RocketChat/Rocket.Chat), the team deliberately chose to use `rm -rf dist` directly in the `"build"` script instead of `rimraf`, as they decided against introducing the `rimraf` dependency for this package. Do not flag `rm -rf dist` in the ui-voip build script as a cross-platform issue requiring rimraf.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
📚 Learning: 2026-02-24T19:36:55.089Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/page-objects/fragments/home-content.ts:60-82
Timestamp: 2026-02-24T19:36:55.089Z
Learning: In RocketChat/Rocket.Chat e2e tests (apps/meteor/tests/e2e/page-objects/fragments/home-content.ts), thread message preview listitems do not have aria-roledescription="message", so lastThreadMessagePreview locator cannot be scoped to messageListItems (which filters for aria-roledescription="message"). It should remain scoped to page.getByRole('listitem') or mainMessageList.getByRole('listitem').
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Avoid using `page.locator()` in Playwright tests - always prefer semantic locators such as `page.getByRole()`, `page.getByLabel()`, `page.getByText()`, or `page.getByTitle()`
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,spec.ts} : Follow Page Object Model pattern consistently in Playwright tests
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Prefer web-first assertions (`toBeVisible`, `toHaveText`, etc.) in Playwright tests
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/page-objects/**/*.ts : Utilize existing page objects pattern from `apps/meteor/tests/e2e/page-objects/`
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-09-23T19:22:59.217Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 36987
File: apps/meteor/tests/e2e/page-objects/fragments/room-toolbar.ts:10-20
Timestamp: 2025-09-23T19:22:59.217Z
Learning: In Playwright e2e tests, prefer stable selectors like data-qa-id attributes over localized text in getByRole() or getByText() calls to prevent test failures when UI language changes. Test translations separately by validating actual text content after ensuring UI interactions work with stable selectors.
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Utilize Playwright fixtures (`test`, `page`, `expect`) for consistency in test files
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tspackages/ui-voip/package.jsonapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2026-02-24T19:22:52.984Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:52.984Z
Learning: In RocketChat/Rocket.Chat Playwright e2e tests, prefer using translated text and ARIA roles (getByRole, getByText, etc.) over data-qa locators. If translation values change, update the corresponding test locators accordingly. Never prefer data-qa locators.
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,spec.ts} : Store commonly used locators in variables/constants for reuse
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Implement proper wait strategies for dynamic content in Playwright tests
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-12-16T17:29:40.430Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37834
File: apps/meteor/tests/e2e/page-objects/fragments/admin-flextab-emoji.ts:12-22
Timestamp: 2025-12-16T17:29:40.430Z
Learning: In all page-object files under apps/meteor/tests/e2e/page-objects/, import expect from ../../utils/test (Playwright's async expect) instead of from Jest. Jest's expect is synchronous and incompatible with web-first assertions like toBeVisible, which can cause TypeScript errors.
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2026-02-24T19:39:42.247Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/page-objects/fragments/message.ts:7-7
Timestamp: 2026-02-24T19:39:42.247Z
Learning: In RocketChat e2e tests, avoid using data-qa attributes to locate elements. Prefer semantic locators such as getByRole, getByLabel, getByText, getByTitle and ARIA-based selectors. Apply this rule to all TypeScript files under apps/meteor/tests/e2e to improve test reliability, accessibility, and maintainability.
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.tsapps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tsapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.tsapps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `expect` matchers for assertions (`toEqual`, `toContain`, `toBeTruthy`, `toHaveLength`, etc.) instead of `assert` statements in Playwright tests
Applied to files:
apps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsx
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `test.step()` for complex test scenarios to improve organization in Playwright tests
Applied to files:
apps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Maintain test isolation between test cases in Playwright tests
Applied to files:
apps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.tspackages/ui-client/src/components/CustomFieldsForm.spec.tsx
📚 Learning: 2026-02-24T19:05:56.710Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
Applied to files:
packages/ui-composer/package.jsonpackages/ui-contexts/package.jsonpackages/storybook-config/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/package.jsonapps/uikit-playground/package.jsonpackages/ui-video-conf/package.jsonapps/meteor/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.jsonpackages/ui-avatar/package.jsonpackages/ui-client/package.json
📚 Learning: 2026-03-17T16:08:37.572Z
Learnt from: cardoso
Repo: RocketChat/Rocket.Chat PR: 39690
File: packages/ui-voip/package.json:11-11
Timestamp: 2026-03-17T16:08:37.572Z
Learning: In `packages/ui-voip/package.json` (RocketChat/Rocket.Chat), the team deliberately chose to use `rm -rf dist` directly in the `"build"` script instead of `rimraf`, as they decided against introducing the `rimraf` dependency for this package. Do not flag `rm -rf dist` in the ui-voip build script as a cross-platform issue requiring rimraf.
Applied to files:
packages/ui-composer/package.jsonpackages/ui-contexts/package.jsonpackages/storybook-config/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/package.jsonapps/uikit-playground/package.jsonpackages/ui-video-conf/package.jsonapps/meteor/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.jsonpackages/ui-avatar/package.jsonpackages/ui-client/package.json
📚 Learning: 2026-02-24T19:05:56.710Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: In Rocket.Chat PRs, keep feature PRs free of unrelated lockfile-only dependency bumps; prefer reverting lockfile drift or isolating such bumps into a separate "chore" commit/PR, and always use yarn install --immutable with the Yarn version pinned in package.json via Corepack.
Applied to files:
packages/ui-composer/package.jsonpackages/ui-contexts/package.jsonpackages/storybook-config/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/package.jsonapps/uikit-playground/package.jsonpackages/ui-video-conf/package.jsonapps/meteor/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.jsonpackages/ui-avatar/package.jsonpackages/ui-client/package.json
📚 Learning: 2026-02-25T20:10:16.987Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38913
File: packages/ddp-client/src/legacy/types/SDKLegacy.ts:34-34
Timestamp: 2026-02-25T20:10:16.987Z
Learning: In the RocketChat/Rocket.Chat monorepo, packages/ddp-client and apps/meteor do not use TypeScript project references. Module augmentations in apps/meteor (e.g., declare module 'rocket.chat/rest-typings') are not visible when compiling packages/ddp-client in isolation, which is why legacy SDK methods that depend on OperationResult types for OpenAPI-migrated endpoints must remain commented out.
Applied to files:
packages/ui-contexts/package.jsonpackages/storybook-config/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/package.jsonapps/uikit-playground/package.jsonapps/meteor/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.jsonpackages/ui-avatar/package.jsonpackages/ui-client/package.json
📚 Learning: 2025-11-19T12:32:29.696Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
Applied to files:
packages/ui-contexts/package.json
📚 Learning: 2026-04-14T23:23:18.990Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 40159
File: packages/apps-engine/turbo.json:6-6
Timestamp: 2026-04-14T23:23:18.990Z
Learning: In RocketChat/Rocket.Chat's Turborepo setup, the workspace-root `package.json` is part of Turbo's global hash and does not need to be explicitly listed in a package-level turbo.json task's `inputs` array. Changes to the root `package.json` already bust the cache for all tasks via the global hash. Do not flag the absence of `$TURBO_ROOT$/package.json` in task-level inputs as a cache-invalidation issue.
Applied to files:
packages/ui-contexts/package.jsonpackages/gazzodown/package.jsonapps/meteor/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.json
📚 Learning: 2025-12-10T21:00:54.909Z
Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:54.909Z
Learning: Rocket.Chat monorepo: Jest testMatch pattern '<rootDir>/src/**/*.spec.(ts|js|mjs)' is valid in this repo and used across multiple packages (e.g., packages/tools, ee/packages/omnichannel-services). Do not flag it as invalid in future reviews.
Applied to files:
packages/fuselage-ui-kit/package.jsonapps/meteor/package.jsonpackages/ui-voip/package.jsonpackages/ui-client/package.json
📚 Learning: 2026-02-24T19:09:09.561Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.
Applied to files:
packages/gazzodown/package.jsonapps/uikit-playground/package.jsonpackages/ui-video-conf/package.jsonapps/meteor/package.jsonpackages/ui-client/package.json
📚 Learning: 2025-12-16T17:29:45.163Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37834
File: apps/meteor/tests/e2e/page-objects/fragments/admin-flextab-emoji.ts:12-22
Timestamp: 2025-12-16T17:29:45.163Z
Learning: In page object files under `apps/meteor/tests/e2e/page-objects/`, always import `expect` from `../../utils/test` (Playwright's async expect), not from Jest. Jest's `expect` has a synchronous signature and will cause TypeScript errors when used with web-first assertions like `toBeVisible()`.
Applied to files:
packages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.spec.ts : Use descriptive test names that clearly communicate expected behavior in Playwright tests
Applied to files:
packages/ui-client/src/components/CustomFieldsForm.spec.tsx
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure clean state for each test execution in Playwright tests
Applied to files:
packages/ui-client/src/components/CustomFieldsForm.spec.tsx
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `test.beforeAll()` and `test.afterAll()` for setup/teardown in Playwright tests
Applied to files:
packages/ui-client/src/components/CustomFieldsForm.spec.tsx
📚 Learning: 2026-03-06T18:10:15.268Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.
Applied to files:
packages/ui-client/src/components/CustomFieldsForm.spec.tsxapps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
packages/ui-client/src/components/CustomFieldsForm.spec.tsx
📚 Learning: 2026-03-16T21:50:42.118Z
Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:42.118Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs, removing endpoint types and validators from `rocket.chat/rest-typings` (e.g., `UserRegisterParamsPOST`, `/v1/users.register` entry) is the *required* migration pattern per RocketChat/Rocket.Chat-Open-API#150 Rule 7 ("No More rest-typings or Manual Typings"). The endpoint type is re-exposed via a module augmentation `.d.ts` file in the consuming package (e.g., `packages/web-ui-registration/src/users-register.d.ts`). This is NOT a breaking change — the correct changeset bump for `rocket.chat/rest-typings` in this scenario is `minor`, not `major`. Do not flag this as a breaking change during OpenAPI migration reviews.
Applied to files:
apps/uikit-playground/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.jsonpackages/ui-client/package.json
📚 Learning: 2026-03-14T14:58:58.834Z
Learnt from: smirk-dev
Repo: RocketChat/Rocket.Chat PR: 39625
File: apps/meteor/app/api/server/v1/push.ts:85-97
Timestamp: 2026-03-14T14:58:58.834Z
Learning: In RocketChat/Rocket.Chat, the `push.token` POST/DELETE endpoints in `apps/meteor/app/api/server/v1/push.ts` were already migrated to the chained router API pattern on `develop` prior to PR `#39625`. `cleanTokenResult` (which strips `authToken` and returns `PushTokenResult`) and `isPushTokenPOSTProps`/`isPushTokenDELETEProps` validators already exist on `develop`. PR `#39625` only migrates `push.get` and `push.info` to the chained pattern. Do not flag `cleanTokenResult` or `PushTokenResult` as newly introduced behavior-breaking changes when reviewing this PR.
Applied to files:
apps/meteor/package.json
📚 Learning: 2026-04-17T18:33:27.211Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 39858
File: apps/meteor/tests/e2e/apps/uikit-interactions.spec.ts:123-151
Timestamp: 2026-04-17T18:33:27.211Z
Learning: In RocketChat/Rocket.Chat (`apps/meteor/tests/e2e/apps/uikit-interactions.spec.ts`), `executeBlockActionHandler` invocations originating from a **modal** surface intentionally do NOT include a `block_action_room` (room property) in the interaction payload. Modals are not scoped to a room, so no room id is available in that context. Do not flag the absence of a room assertion in the modal block-action test as a missing coverage bug; instead, document it explicitly with a `test.step` asserting the room entry is `undefined`.
Applied to files:
apps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.tsapps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts
📚 Learning: 2026-02-24T19:22:48.358Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.
Applied to files:
apps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
📚 Learning: 2026-03-02T16:31:41.304Z
Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 39250
File: apps/meteor/tests/end-to-end/api/livechat/07-queue.ts:1084-1094
Timestamp: 2026-03-02T16:31:41.304Z
Learning: In E2E API tests at apps/meteor/tests/end-to-end/api/livechat/, using sleep(1000) after updateSetting() or updateEESetting() calls in test setup hooks is acceptable and intentional to allow omnichannel settings to propagate their side effects.
Applied to files:
apps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
📚 Learning: 2026-03-16T11:50:18.066Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 39657
File: apps/meteor/tests/end-to-end/apps/app-resolve-visitor.ts:18-21
Timestamp: 2026-03-16T11:50:18.066Z
Learning: In `apps/meteor/tests/end-to-end/apps/` (and Livechat E2E tests broadly), calling `createAgent()` and `makeAgentAvailable()` immediately after `updateSetting('Livechat_enabled', true)` — without any intermediate sleep — is an established, non-flaky pattern used across 10+ tests in the codebase. Do not flag this sequence as a potential race condition or suggest adding a delay between them.
Applied to files:
apps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts
📚 Learning: 2026-03-06T18:09:17.867Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/elements/Timestamp/DateTimeFormats.spec.tsx:20-23
Timestamp: 2026-03-06T18:09:17.867Z
Learning: In the RocketChat/Rocket.Chat gazzodown package (`packages/gazzodown`), tests are intended to run under the UTC timezone, but as of PR `#39397` this is NOT yet explicitly enforced in `jest.config.ts` or the `package.json` test scripts (which just run `jest` without `TZ=UTC`). To make timezone-sensitive snapshot tests reliable across all environments, `TZ=UTC` should be added to the test scripts in `package.json` or to `jest.config.ts` via `testEnvironmentOptions.timezone`. Without explicit UTC enforcement, snapshot tests involving date-fns formatted output or `toLocaleString()` will fail for contributors in non-UTC timezones.
Applied to files:
packages/ui-voip/package.json
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `page.waitFor()` with specific conditions instead of hardcoded timeouts in Playwright tests
Applied to files:
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts
🔇 Additional comments (21)
packages/ui-client/src/components/CustomFieldsForm.spec.tsx (3)
3-3: Import cleanup matches the selector update.Dropping
withinhere is correct after moving to direct role queries on the select trigger.
53-53: Selector now matches the upgraded Select accessibility surface.Using
getByRole('button', { name: /Field 2/ })is the right adjustment for the Fuselage select trigger.
83-83: Good consistency with the select-specific test case.This assertion is aligned with the “render all fields” test and reduces brittleness versus hidden combobox targeting.
packages/ui-contexts/package.json (1)
26-26: Dependency bump is consistent with the PR scope.The
@rocket.chat/fuselagedevDependency update is clean and aligned with the monorepo-wide upgrade.packages/storybook-config/package.json (1)
39-39: Looks good for Storybook config alignment.This version bump is straightforward and matches the dependency upgrade rollout.
packages/ui-composer/package.json (1)
25-25: Scoped dependency update is good.No concerns with this
@rocket.chat/fuselagebump inui-composer.packages/ui-avatar/package.json (1)
20-20: LGTM for dependency harmonization.This is a clean, in-scope package update.
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-livechat-appearance.ts (1)
7-7: Page-object locator update is fine.This keeps the selector encapsulated in the page object and aligns with the updated control targeting.
Based on learnings: In Rocket.Chat/Rocket.Chat Playwright e2e tests, prefer using translated text and ARIA roles (getByRole, getByText, etc.) over data-qa locators; update locators when translation values change.
packages/gazzodown/package.json (1)
32-32: UI dependency trio bump is coherent.The
css-in-js,fuselage, andstyledupdates are aligned and appropriately scoped.Also applies to: 34-34, 40-40
packages/ui-video-conf/package.json (1)
24-25: Version alignment looks good.No issues found with these coordinated UI dependency bumps.
Also applies to: 30-30
apps/meteor/tests/e2e/page-objects/fragments/flextabs/members-flextab.ts (1)
38-38: Combobox role update is correct.Switching to
getByRole('combobox', { name: 'Choose users' })matches the updated input semantics and keeps the flow stable.As per coding guidelines: “Follow Page Object Model pattern consistently in Playwright tests” and “Store commonly used locators in variables/constants for reuse.”
packages/ui-client/package.json (1)
27-27: Dependency alignment looks clean and consistent.These version bumps are coherent with the repo-wide Fuselage upgrade and keep this workspace aligned with the updated UI stack.
Also applies to: 29-29, 39-39
apps/meteor/tests/e2e/page-objects/omnichannel/omnichannel-reports.ts (1)
18-18: Good selector update for period control.Scoping the ARIA-labeled button to the section keeps the locator reusable and matches the existing page-object approach.
packages/fuselage-ui-kit/package.json (1)
49-49: Version bumps are scoped correctly.The updated Fuselage and Styled devDependency ranges are consistent with the intended upgrade set.
Also applies to: 55-55
apps/meteor/package.json (1)
104-104: Meteor dependency bump set is coherent.The updated versions match the PR’s declared Fuselage package upgrade scope without introducing unrelated manifest churn.
Also applies to: 109-110, 151-151
apps/uikit-playground/package.json (1)
20-21: Playground manifest stays aligned with the upgraded UI stack.These dependency updates are consistent and appropriately scoped.
Also applies to: 28-28
packages/ui-voip/package.json (1)
32-33: UI-VoIP dependency updates are consistent with the PR goal.The bumped devDependencies align with the broader package upgrade and look clean.
Also applies to: 40-40
apps/meteor/tests/e2e/omnichannel/omnichannel-appearance.spec.ts (1)
32-32: Nice stability improvement in dropdown interaction.Clicking the page-object control directly is less brittle than icon-targeted clicks and keeps the scenario behavior intact.
Also applies to: 36-36, 40-40, 48-48
packages/web-ui-registration/package.json (1)
24-24: Registration package bump is correctly scoped.The dependency changes are aligned with the same upgrade strategy used across this PR.
Also applies to: 26-26
apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts (2)
38-40: Good move to a role-basedcomboboxlocator.This aligns the page object with the updated member-picker semantics and keeps locator intent clear.
72-72:autocompleteUserupdate tocomboboxlooks correct.This is consistent with the upgraded UI control behavior and keeps the locator semantic.
dougfabris
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed for WA-74
Proposed changes (including videos or screenshots)
Release changes:
@rocket.chat/styled@0.32.1
@rocket.chat/fuselage@0.77.0
@rocket.chat/fuselage-forms@1.2.0
@rocket.chat/css-in-js@0.32.0
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Chores
Tests
Style