Skip to content

chore(deps): bump pbdkf2 inside browserify#40457

Merged
julio-rocketchat merged 1 commit into
release-8.2.3from
bump-pbkdf2
May 8, 2026
Merged

chore(deps): bump pbdkf2 inside browserify#40457
julio-rocketchat merged 1 commit into
release-8.2.3from
bump-pbkdf2

Conversation

@julio-rocketchat
Copy link
Copy Markdown
Member

@julio-rocketchat julio-rocketchat commented May 8, 2026

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Updated a dependency version to improve stability and compatibility.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented May 8, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

⚠️ No Changeset found

Latest commit: aaffb45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ddb190c-c520-41b5-8e8c-1c3a6824e195

📥 Commits

Reviewing files that changed from the base of the PR and between 7f12aab and aaffb45.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (1)
package.json (1)

68-68: Resolution pin is consistent with current transitive override strategy.

This new crypto-browserify/pbkdf2 entry matches the existing pbkdf2 pinning pattern in the same resolutions block.


Walkthrough

A Yarn resolutions override is added to package.json to pin crypto-browserify/pbkdf2 to version 3.1.3.

Changes

Dependency Resolution

Layer / File(s) Summary
Dependency Resolution Override
package.json
Yarn resolutions entry pins crypto-browserify/pbkdf2 to version 3.1.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly describes the main change: bumping the pbkdf2 dependency within browserify via a Yarn resolutions entry in package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.2.3@7f12aab). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-8.2.3   #40457   +/-   ##
================================================
  Coverage                 ?   70.49%           
================================================
  Files                    ?     3194           
  Lines                    ?   112876           
  Branches                 ?    20447           
================================================
  Hits                     ?    79573           
  Misses                   ?    31245           
  Partials                 ?     2058           
Flag Coverage Δ
e2e 60.39% <ø> (?)
e2e-api 48.96% <ø> (?)
unit 71.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat julio-rocketchat merged commit c061820 into release-8.2.3 May 8, 2026
44 checks passed
@julio-rocketchat julio-rocketchat deleted the bump-pbkdf2 branch May 8, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant