Skip to content

refactor(core-typings): remove _updatedAt from IInstanceStatus#40507

Merged
ggazzo merged 1 commit into
developfrom
refactor/instance-status-updated-at
May 14, 2026
Merged

refactor(core-typings): remove _updatedAt from IInstanceStatus#40507
ggazzo merged 1 commit into
developfrom
refactor/instance-status-updated-at

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented May 13, 2026

The related model is prevented from setting the _updatedAt field.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Task: ARCH-2146

Summary by CodeRabbit

  • Refactor

    • Simplified instance status type definitions and removed the "Updated at" timestamp from the Instances modal display.
  • Chores

    • Updated the Instances modal story to reflect the adjusted timestamps shown in the component preview.

Review Change Stack

@tassoevan tassoevan requested review from a team as code owners May 13, 2026 14:50
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented May 13, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

⚠️ No Changeset found

Latest commit: 2bae1ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c23d1950-2e70-4855-9685-f8418ae1225c

📥 Commits

Reviewing files that changed from the base of the PR and between add35fe and 2bae1ac.

📒 Files selected for processing (3)
  • apps/meteor/client/views/admin/workspace/DeploymentCard/components/InstancesModal/InstancesModal.stories.tsx
  • apps/meteor/client/views/admin/workspace/DeploymentCard/components/InstancesModal/InstancesModal.tsx
  • packages/core-typings/src/IInstanceStatus.ts
💤 Files with no reviewable changes (2)
  • apps/meteor/client/views/admin/workspace/DeploymentCard/components/InstancesModal/InstancesModal.stories.tsx
  • apps/meteor/client/views/admin/workspace/DeploymentCard/components/InstancesModal/InstancesModal.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

  • packages/core-typings/src/IInstanceStatus.ts
🧠 Learnings (3)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.

Applied to files:

  • packages/core-typings/src/IInstanceStatus.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.

Applied to files:

  • packages/core-typings/src/IInstanceStatus.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

  • packages/core-typings/src/IInstanceStatus.ts
🔇 Additional comments (1)
packages/core-typings/src/IInstanceStatus.ts (1)

1-2: ⚡ Quick win

Change is correct—IInstanceStatus is properly decoupled from IRocketChatRecord.

Verification confirms:

  • IRocketChatRecord provides _id: string and _updatedAt: Date; removing the extends relationship successfully removes _updatedAt
  • Explicit _id: string matches the inherited type
  • No remaining _updatedAt usages on IInstanceStatus objects

Walkthrough

The PR removes _updatedAt tracking from instance status. The IInstanceStatus interface is decoupled from IRocketChatRecord, explicitly declaring its own _id field. The InstancesModal component and its story fixture are updated to remove references to the deleted field.

Changes

Remove _updatedAt from instance status

Layer / File(s) Summary
IInstanceStatus type contract
packages/core-typings/src/IInstanceStatus.ts
IInstanceStatus no longer extends IRocketChatRecord; the import is removed and _id is explicitly declared within the interface.
InstancesModal component and story updates
apps/meteor/client/views/admin/workspace/DeploymentCard/components/InstancesModal/InstancesModal.tsx, apps/meteor/client/views/admin/workspace/DeploymentCard/components/InstancesModal/InstancesModal.stories.tsx
The modal stops rendering the "Instance_Record > Updated_at" field, and the story fixture removes the _updatedAt property from test data.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing _updatedAt from IInstanceStatus interface, which is reflected across all modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • ARCH-2146: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tassoevan tassoevan added this to the 8.5.0 milestone May 13, 2026
@tassoevan
Copy link
Copy Markdown
Member Author

/jira ARCH-2113

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.58%. Comparing base (ab4df95) to head (2bae1ac).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40507      +/-   ##
===========================================
- Coverage    69.60%   69.58%   -0.02%     
===========================================
  Files         3323     3323              
  Lines       122610   122610              
  Branches     21888    21857      -31     
===========================================
- Hits         85337    85318      -19     
- Misses       33939    33956      +17     
- Partials      3334     3336       +2     
Flag Coverage Δ
unit 70.31% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The related model is prevented from setting the `_updatedAt` field.
@tassoevan tassoevan force-pushed the refactor/instance-status-updated-at branch from add35fe to 2bae1ac Compare May 13, 2026 17:02
@ggazzo ggazzo merged commit 6bcc08c into develop May 14, 2026
77 of 83 checks passed
@ggazzo ggazzo deleted the refactor/instance-status-updated-at branch May 14, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants