regression: thread not scrolling on receiving new message#40642
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
|
Contributor
WalkthroughTwo files update message-jump behavior: the jump effect now exits early when no target message is found and clears highlights faster (500ms), while the thread message list clears the ChangesMessage Jump Robustness and Thread Navigation Cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx (1)
117-137:⚠️ Potential issue | 🟠 Major | ⚡ Quick winClear
msgwhen jump target cannot be resolved.Right now, unresolved targets (
threadMsgTargetIndex < 0) keepmsgin the URL, while the other effect keeps forcingshouldJumpToBottomoff whenevermsgis present. That can leave thread scroll behavior degraded until a manual URL cleanup.Proposed fix
useEffect(() => { - if (threadMsgTargetIndex < 0 || !msgJumpParam) { + if (!msgJumpParam) { return; } + if (threadMsgTargetIndex < 0) { + setMessageJumpQueryStringParameter(null); + return; + } const jumpKey = `${mainMessage._id}:${msgJumpParam}`; if (lastThreadJumpKeyRef.current === jumpKey) { return; } @@ -}, [threadMsgTargetIndex, msgJumpParam, mainMessage._id, setShouldJumpToBottom]); +}, [threadMsgTargetIndex, msgJumpParam, mainMessage._id, setShouldJumpToBottom]);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx` around lines 117 - 137, When the jump target can't be resolved (threadMsgTargetIndex < 0) the effect currently returns early but leaves the msg in the URL; update the early-return branch of the useEffect (the one referencing threadMsgTargetIndex and msgJumpParam) to clear the jump query by calling setMessageJumpQueryStringParameter(null) (and optionally clear highlight state if needed) so the URL-driven logic and setShouldJumpToBottom don't get stuck; keep the rest of the logic (lastThreadJumpKeyRef, scrollToIndex, setHighlightMessage) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx`:
- Around line 117-137: When the jump target can't be resolved
(threadMsgTargetIndex < 0) the effect currently returns early but leaves the msg
in the URL; update the early-return branch of the useEffect (the one referencing
threadMsgTargetIndex and msgJumpParam) to clear the jump query by calling
setMessageJumpQueryStringParameter(null) (and optionally clear highlight state
if needed) so the URL-driven logic and setShouldJumpToBottom don't get stuck;
keep the rest of the logic (lastThreadJumpKeyRef, scrollToIndex,
setHighlightMessage) unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c2a28658-bf1b-45b9-9ef1-3324a25bc16c
📒 Files selected for processing (2)
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.tsapps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: 📦 Build Packages
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
- GitHub Check: Hacktron Security Check
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.tsapps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
🧠 Learnings (6)
📚 Learning: 2026-02-10T16:32:42.586Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38528
File: apps/meteor/client/startup/roles.ts:14-14
Timestamp: 2026-02-10T16:32:42.586Z
Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON and Date fields arrive as Date objects; do not manually construct new Date() in stream handlers (for example, in sdk.stream()). Only REST API responses return plain JSON where dates are strings, so implement explicit conversion there if needed. Apply this guidance to all TypeScript files under apps/meteor/client to ensure consistent date handling in DDP streams and REST responses.
Applied to files:
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.ts
📚 Learning: 2026-05-11T20:30:35.265Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 40480
File: apps/meteor/client/meteor/startup/accounts.ts:59-61
Timestamp: 2026-05-11T20:30:35.265Z
Learning: In Rocket.Chat’s Meteor client code, when calling `dispatchToastMessage` with `{ type: 'error' }`, pass the raw caught error object as `message` without manual normalization. `dispatchToastMessage` is designed to accept `message: unknown` for error toasts, so avoid converting errors to strings (e.g., `String(error)`) or extracting `error.message` before passing them.
Applied to files:
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.tsapps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
🔇 Additional comments (2)
apps/meteor/client/views/room/MessageList/hooks/useTryToJumpToMessage.ts (1)
41-43: LGTM!Also applies to: 84-84
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx (1)
27-27: LGTM!Also applies to: 77-77, 107-110, 133-133
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx (1)
107-115: 💤 Low valueDrop redundant optional chaining and the unused effect dep.
handleis already narrowed to non-null at line 100, sohandle?.scrollSize(twice) can behandle.scrollSize. Also,threadMsgTargetIndexis listed in the dependency array but never referenced inside this effect; the jump logic lives in the separate effect below. Removing it avoids needless re-runs on jump-target changes.♻️ Proposed change
- if (isAtBottom.current && lastScrollSizeRef.current !== handle?.scrollSize) { - lastScrollSizeRef.current = handle?.scrollSize ?? 0; + if (isAtBottom.current && lastScrollSizeRef.current !== handle.scrollSize) { + lastScrollSizeRef.current = handle.scrollSize; setShouldJumpToBottom(true); } if (shouldJumpToBottom) { handle.scrollToIndex(items.length, { align: 'end' }); setShouldJumpToBottom(false); } - }, [loading, items.length, msgJumpParam, threadMsgTargetIndex, shouldJumpToBottom, setShouldJumpToBottom]); + }, [loading, items.length, msgJumpParam, shouldJumpToBottom, setShouldJumpToBottom]);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx` around lines 107 - 115, The effect is using redundant optional chaining and includes an unused dependency; replace both occurrences of handle?.scrollSize with handle.scrollSize (since handle is narrowed non-null around line 100) when updating lastScrollSizeRef.current and comparing, and remove threadMsgTargetIndex from the effect's dependency array so the effect only depends on loading, items.length, msgJumpParam, shouldJumpToBottom, and setShouldJumpToBottom; keep the rest of the logic (isAtBottom.current check, setShouldJumpToBottom(true), and the scrollToIndex call) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx`:
- Around line 107-115: The effect is using redundant optional chaining and
includes an unused dependency; replace both occurrences of handle?.scrollSize
with handle.scrollSize (since handle is narrowed non-null around line 100) when
updating lastScrollSizeRef.current and comparing, and remove
threadMsgTargetIndex from the effect's dependency array so the effect only
depends on loading, items.length, msgJumpParam, shouldJumpToBottom, and
setShouldJumpToBottom; keep the rest of the logic (isAtBottom.current check,
setShouldJumpToBottom(true), and the scrollToIndex call) unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 06cb8286-766c-47b1-b658-fc51d9f18f7b
📒 Files selected for processing (1)
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
🧠 Learnings (2)
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx
🔇 Additional comments (1)
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx (1)
117-137: ⚡ Quick winPlease provide the original
<review_comment>text (and any referenced file/diff context) so I can rewrite it accurately based on the verification results.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5.0 #40642 +/- ##
================================================
Coverage ? 69.65%
================================================
Files ? 3338
Lines ? 123236
Branches ? 22006
================================================
Hits ? 85846
Misses ? 34032
Partials ? 3358
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cardoso
approved these changes
May 22, 2026
cardoso
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
CORE-2215
Steps to test or reproduce
Further comments
Summary by CodeRabbit