Skip to content

regression: remove unnecessary <li> item#40645

Merged
dionisio-bot[bot] merged 2 commits into
release-8.5.0from
reg-remove-ball
May 26, 2026
Merged

regression: remove unnecessary <li> item#40645
dionisio-bot[bot] merged 2 commits into
release-8.5.0from
reg-remove-ball

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented May 21, 2026

Proposed changes (including videos or screenshots)

Issue(s)

CORE-2244

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Refactor
    • Adjusted the wrapper used around thread message previews (changed surrounding element/role) while preserving the preview content, attributes, and behavior — this modifies the DOM structure without altering visible functionality.

Review Change Stack

@MartinSchoeler MartinSchoeler requested a review from a team as a code owner May 21, 2026 17:43
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented May 21, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

⚠️ No Changeset found

Latest commit: 2c728d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eba82015-0041-4265-9c85-8e4289de62f1

📥 Commits

Reviewing files that changed from the base of the PR and between cb79d65 and 2c728d8.

📒 Files selected for processing (1)
  • apps/meteor/client/views/room/MessageList/MessageListItem.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/meteor/client/views/room/MessageList/MessageListItem.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build

Walkthrough

MessageListItem now wraps ThreadMessagePreview in a

instead of an HTML
  • , preserving all props (message, showUserAvatar, sequencing) and data-* attributes; DOM structure for thread messages is simplified.

    Changes

    MessageListItem ThreadMessagePreview Rendering

    Layer / File(s) Summary
    Swap list wrapper element
    apps/meteor/client/views/room/MessageList/MessageListItem.tsx
    Replaces the <li> wrapper with a <div role='listitem'> around ThreadMessagePreview; all props and data-* attributes are preserved.

    Estimated code review effort

    🎯 1 (Trivial) | ⏱️ ~3 minutes

    Suggested labels

    type: bug

    Suggested reviewers

    • cardoso
    • tassoevan
    🚥 Pre-merge checks | ✅ 5
    ✅ Passed checks (5 passed)
    Check name Status Explanation
    Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
    Title check ✅ Passed The title directly describes the main change: replacing an unnecessary <li> wrapper with a div role="listitem" wrapper in MessageListItem, which is the core modification in the changeset.
    Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
    Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
    Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

    ✏️ Tip: You can configure your own custom pre-merge checks in the settings.

    [!WARNING]

    Review ran into problems

    🔥 Problems

    Errors were encountered while retrieving linked issues.

    Errors (1)
    • CORE-2244: Request failed with status code 401

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❤️ Share

    Comment @coderabbitai help to get the list of available commands and usage tips.

  • Copy link
    Copy Markdown
    Contributor

    @cubic-dev-ai cubic-dev-ai Bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No issues found across 1 file

    Re-trigger cubic

    @codecov
    Copy link
    Copy Markdown

    codecov Bot commented May 21, 2026

    Codecov Report

    ✅ All modified and coverable lines are covered by tests.
    ⚠️ Please upload report for BASE (release-8.5.0@80b90cd). Learn more about missing BASE report.

    Additional details and impacted files

    Impacted file tree graph

    @@               Coverage Diff                @@
    ##             release-8.5.0   #40645   +/-   ##
    ================================================
      Coverage                 ?   69.67%           
    ================================================
      Files                    ?     3338           
      Lines                    ?   123265           
      Branches                 ?    21926           
    ================================================
      Hits                     ?    85886           
      Misses                   ?    34024           
      Partials                 ?     3355           
    Flag Coverage Δ
    unit 70.50% <ø> (?)

    Flags with carried forward coverage won't be shown. Click here to find out more.

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
    • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

    @MartinSchoeler MartinSchoeler added this to the 8.5.0 milestone May 25, 2026
    @MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label May 25, 2026
    @dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels May 25, 2026
    Comment thread apps/meteor/client/views/room/MessageList/MessageListItem.tsx Outdated
    @coderabbitai coderabbitai Bot removed the type: bug label May 26, 2026
    MartinSchoeler and others added 2 commits May 26, 2026 20:53
    @dionisio-bot dionisio-bot Bot merged commit caf0b1b into release-8.5.0 May 26, 2026
    11 of 12 checks passed
    @dionisio-bot dionisio-bot Bot deleted the reg-remove-ball branch May 26, 2026 23:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: bug

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants