refactor: swap method.call/addUsersToRoom for per-type REST endpoints

[Copilot]

The addUserToRoom test helper used the legacy DDP method.call/addUsersToRoom endpoint. Federation tests asserted the DDP error shape (JSON.parse(body.message).error.error) instead of the REST envelope ({ success: false, errorType }).

Changes

• apps/meteor/tests/data/rooms.helper.ts — Added required type: IRoom['t'] parameter routing to the appropriate endpoint:

  • 'c' → POST /v1/channels.invite
  • 'p' → POST /v1/groups.invite
  • 'd' → falls back to method.call (no REST equivalent for DM invites)

• Federation test assertions (room.spec.ts, permissions.spec.ts) — Migrated from DDP error shape to REST envelope:

  - const messageData = JSON.parse(response.body.message);
  - expect(messageData.error).toHaveProperty('error', 'error-federated-users-in-non-federated-rooms');
  + expect(response.body).toHaveProperty('errorType', 'error-federated-users-in-non-federated-rooms');

  Success assertions updated from DDP result string (body.message matching {"msg":"result",...}) to REST shape (body.group).

• DM tests (dms.spec.ts) — Pass type: 'd'; assertions unchanged since DDP fallback is preserved.

• Other callers (chat.ts, uploads.helper.ts) — Pass explicit room type.

Task: FGA-67

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8dce3ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.73%. Comparing base (1a4d0f3) to head (8dce3ac).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #40723      +/-   ##
===========================================
+ Coverage    69.72%   69.73%   +0.01%     
===========================================
  Files         3326     3326              
  Lines       123056   123090      +34     
  Branches     21976    21948      -28     
===========================================
+ Hits         85797    85835      +38     
  Misses       33905    33905              
+ Partials      3354     3350       -4     

Flag	Coverage Δ
unit	70.47% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ggazzo]

@copilot check lint task

[Copilot]

@copilot check lint task

The lint failure was two prettier errors in rooms.helper.ts — the chained .post().set() calls needed to be on a single line instead of split across multiple lines. Fixed in 3rd commit.

[ggazzo]

/jira FGA

[dionisio-bot]

⚠️ Dionisio (Jira)

The milestone "8.6.0" does not exist on the Jira board; the task was created without Fix version.