Skip to content

test(ui-client): clear up runtime warnings#40772

Merged
tassoevan merged 3 commits into
developfrom
refactor/fuselage-warnings-on-ui-client
Jun 3, 2026
Merged

test(ui-client): clear up runtime warnings#40772
tassoevan merged 3 commits into
developfrom
refactor/fuselage-warnings-on-ui-client

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Jun 2, 2026

Proposed changes (including videos or screenshots)

It fixes some runtime warnings in Jest unit tests over @rocket.chat/ui-client.

Issue(s)

Steps to test or reproduce

Further comments

Task: ARCH-2168

Summary by CodeRabbit

  • Style

    • Updated the info icon color in the InfoPanel for improved visual consistency.
  • Tests

    • Updated component and modal tests to run within a mocked app-root/context wrapper, ensuring snapshots and accessibility checks reflect real app context.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jun 2, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 2, 2026

⚠️ No Changeset found

Latest commit: 6ea43e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b2a9186-8eea-44a3-87f3-fb7ecdcf86d3

📥 Commits

Reviewing files that changed from the base of the PR and between 7f234be and 6ea43e9.

📒 Files selected for processing (5)
  • packages/ui-client/src/components/InfoPanel/InfoPanelLabel.tsx
  • packages/ui-client/src/components/Modal/GenericModal/GenericModal.spec.tsx
  • packages/ui-client/src/components/Wizard/Wizard.spec.tsx
  • packages/ui-client/src/components/Wizard/WizardActions.spec.tsx
  • packages/ui-client/src/providers/ModalProvider/ModalProvider.spec.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/ui-client/src/components/InfoPanel/InfoPanelLabel.tsx
🚧 Files skipped from review as they are similar to previous changes (4)
  • packages/ui-client/src/components/Modal/GenericModal/GenericModal.spec.tsx
  • packages/ui-client/src/providers/ModalProvider/ModalProvider.spec.tsx
  • packages/ui-client/src/components/Wizard/WizardActions.spec.tsx
  • packages/ui-client/src/components/Wizard/Wizard.spec.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
  • GitHub Check: Hacktron Security Check

Walkthrough

InfoPanelLabel changes its info Icon color to secondary-info when title is provided. Several spec files (GenericModal, Wizard, WizardActions, ModalProvider) now import mockAppRoot and use mockAppRoot().build() or mockAppRoot().wrap(...).build() as test wrappers.

Changes

Icon Color and Test Infrastructure Updates

Layer / File(s) Summary
Icon color adjustment
packages/ui-client/src/components/InfoPanel/InfoPanelLabel.tsx
Icon color prop is changed from 'font-secondary-info' to 'secondary-info' when title is provided.
Test infrastructure migration to mockAppRoot
packages/ui-client/src/components/Modal/GenericModal/GenericModal.spec.tsx, packages/ui-client/src/components/Wizard/Wizard.spec.tsx, packages/ui-client/src/components/Wizard/WizardActions.spec.tsx, packages/ui-client/src/providers/ModalProvider/ModalProvider.spec.tsx
Test files import mockAppRoot and update render/renderHook wrappers to use mockAppRoot().build() or mockAppRoot().wrap(...).build(), replacing inline wrapper implementations with a consistent app root and Suspense wiring.

🎯 3 (Moderate) | ⏱️ ~20 minutes

type: bug, type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective: clearing up runtime warnings in ui-client tests through test wrapper updates and icon color corrections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • ARCH-2168: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tassoevan tassoevan changed the title fix(ui-client): correct icon color in InfoPanelLabel component test(ui-client): Runtime warnings Jun 2, 2026
@tassoevan tassoevan changed the title test(ui-client): Runtime warnings test(ui-client): clear up runtime warnings Jun 2, 2026
@tassoevan tassoevan force-pushed the refactor/fuselage-warnings-on-ui-client branch from 5a05f51 to 7f234be Compare June 2, 2026 18:30
@tassoevan tassoevan requested a review from a team June 2, 2026 18:32
@tassoevan tassoevan added this to the 8.6.0 milestone Jun 2, 2026
@tassoevan tassoevan marked this pull request as ready for review June 2, 2026 18:32
@tassoevan
Copy link
Copy Markdown
Member Author

/jira ARCH-2167

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.75%. Comparing base (da1de5f) to head (6ea43e9).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40772      +/-   ##
===========================================
- Coverage    69.80%   69.75%   -0.06%     
===========================================
  Files         3327     3327              
  Lines       123135   123135              
  Branches     21983    21956      -27     
===========================================
- Hits         85952    85887      -65     
- Misses       33832    33892      +60     
- Partials      3351     3356       +5     
Flag Coverage Δ
e2e 59.37% <ø> (+0.02%) ⬆️
e2e-api 46.20% <ø> (-0.90%) ⬇️
unit 70.45% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan force-pushed the refactor/fuselage-warnings-on-ui-client branch from 7f234be to 6ea43e9 Compare June 2, 2026 20:27
@tassoevan tassoevan added this pull request to the merge queue Jun 3, 2026
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jun 3, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 3, 2026
@tassoevan tassoevan added this pull request to the merge queue Jun 3, 2026
Merged via the queue into develop with commit f1091be Jun 3, 2026
47 checks passed
@tassoevan tassoevan deleted the refactor/fuselage-warnings-on-ui-client branch June 3, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: bug type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants