refactor(fuselage-hooks): useSafeRefCallback reimplemented callback/cleanup order

[gabriellsh]

Proposed changes (including videos or screenshots)

This fixes an issue where if the passed callback reference were to change, the cleanup function would be lost.
There was no such issue.

The callback calling order was refactored. Now when the component unmounts/rerender, the main callback won't be called - instead, the cleanup function will be called in it's place.

Previously, the cleanup function would be called everytime before the callbackRef was called, even if node was null. This is the default behaviour for refCallbacks, and serves the purpose of communicating that that node stopped existing. Since we now have a cleanup function, this "extra call" with a null node doesn't need to happen anymore, since the cleanup function will be called at this time.

Another consideration that was taken is that, when using callbackRefs, it's very common to see the following pattern:

if (!node) {
    return;
}

Every current use of this hook does this. Since most of the times that's how it's supposed to go, that behavior was abstracted inside the hook by not calling the refCallback when node === null.

Issue(s)

ARCH-1784

Further comments

[changeset-bot]

🦋 Changeset detected

Latest commit: f11ac4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@rocket.chat/fuselage-hooks	Patch
@rocket.chat/logo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gabriellsh]

I incorrectly assumed there was an issue, due to something else in another project. This implementation is better though, but I'll change it a lil' bit so it looks better.