Skip to content

refactor: linter, tsc, federation-sdk and client api#15

Merged
ricardogarim merged 4 commits intomainfrom
feat/send-message
May 19, 2025
Merged

refactor: linter, tsc, federation-sdk and client api#15
ricardogarim merged 4 commits intomainfrom
feat/send-message

Conversation

@ricardogarim
Copy link
Copy Markdown
Member

@ricardogarim ricardogarim commented May 16, 2025

This is the last big PR aimed at wrapping up the foundational work for the project. It includes:

  • Fixes to past linter and typecheck issues that were holding us back.
  • Minor adjustments and refactors to the federation-sdk, especially around signing and making requests.
  • Improvements to internal endpoint structure and service separation** — keeping controllers lean by pushing logic down into their respective services.

We’ve also added some TODOs in the code to track future improvements. From here on out, we'll keep PRs smaller, focused, and easier to review.

Ongoing and upcoming work is being tracked in our Jira board.

@ricardogarim ricardogarim marked this pull request as ready for review May 18, 2025 23:31
@ricardogarim ricardogarim changed the title wip: linter, tsc, federation-sdk and client api refactor: linter, tsc, federation-sdk and client api May 19, 2025
@debdutdeb
Copy link
Copy Markdown
Member

is this using tsserver's default formatter? since i don't see prettier here. or is formatting not part of this pr

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 53.73134% with 31 lines in your changes missing coverage. Please review.

Project coverage is 63.31%. Comparing base (66e6a48) to head (4a040a9).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
packages/homeserver/src/makeRequest.ts 25.00% 15 Missing ⚠️
packages/homeserver/src/events/roomState.ts 10.00% 9 Missing ⚠️
...omeserver/src/procedures/getPublicKeyFromServer.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #15       +/-   ##
===========================================
- Coverage   76.66%   63.31%   -13.36%     
===========================================
  Files          47       25       -22     
  Lines        3450     1829     -1621     
===========================================
- Hits         2645     1158     -1487     
+ Misses        805      671      -134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim
Copy link
Copy Markdown
Member Author

is this using tsserver's default formatter? since i don't see prettier here. or is formatting not part of this pr

we are using biome

@ricardogarim ricardogarim merged commit d092133 into main May 19, 2025
2 checks passed
@debdutdeb
Copy link
Copy Markdown
Member

@ricardogarim how can I get biome to not take over language server - had to disable it because of that

@sampaiodiego sampaiodiego deleted the feat/send-message branch September 26, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants