-
-
Notifications
You must be signed in to change notification settings - Fork 1
BUG: issues with encoding and null field updates #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
82ea8bb
44a2ebc
8cbd939
9114d81
cbefff8
b721e28
2f36252
597aad0
ec9a552
0286681
476f88b
82d55e6
7c4be89
f8c4b79
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ async def read_motor_by_id(self, motor_id: str) -> Optional[MotorModel]: | |
| @repository_exception_handler | ||
| async def update_motor_by_id(self, motor_id: str, motor: MotorModel): | ||
| await self.update_by_id( | ||
| motor.model_dump(exclude_none=True), data_id=motor_id | ||
| motor.model_dump(exclude_none=False), data_id=motor_id | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was not able to initialise fields back to null om update There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably because of some legacy rockets (e.g before drop null was deployed). Could you please test if this is also the case for rockets created after drop null was implemented? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tested some old rockets and motors from April this year and null assignment is working fine for them. Not sure when this migration took place but it looks quite backward compatible. |
||
| ) | ||
|
|
||
| @repository_exception_handler | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.