-
-
Notifications
You must be signed in to change notification settings - Fork 237
Env/flight axial aceleration #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env/flight axial aceleration #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to add axial acceleration calculation to the Flight class, which represents the acceleration along the rocket's longitudinal axis. However, the PR includes several unrelated changes that significantly expand its scope beyond the stated purpose.
Key Changes:
- Added
axial_accelerationproperty to calculate acceleration along rocket's axis - Added corresponding unit test using dot product verification
- Unexpectedly restored previously deprecated export methods (
export_pressures,export_data,export_sensor_data,export_kml) with full implementations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| rocketpy/simulation/flight.py | Added axial_acceleration cached property; restored export methods that were previously moved to FlightDataExporter; removed self.apogee initialization; added json and simplekml imports; removed deprecated import |
| tests/unit/simulation/test_flight.py | Added parameterized test to verify axial_acceleration calculation against manual dot product computation at key flight times |
c5a1258 to
47e5b61
Compare
|
@hogatata are you still willing to work on this one? Tests are not passing, we need that fixed before starting our review |
|
I am still working on this. I will look into the errors and fix the failing tests as soon as possible. @Gui-FernandesBR |
47e5b61 to
660a2df
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
+ Coverage 80.27% 80.78% +0.50%
===========================================
Files 104 107 +3
Lines 12769 13377 +608
===========================================
+ Hits 10250 10806 +556
- Misses 2519 2571 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
234d494 to
51ea94b
Compare
|
@hogatata is this PR ready for review again? Please mark it as ready for review, and solve all the comments above |
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hogatata please update the CHANGELOG.md file so we can approve and merge this PR.
Everything is looking good to me!
51ea94b to
3a41c22
Compare
|
@Gui-FernandesBR Done! I've updated the CHANGELOG.md file. |
Updated docstring for axial_acceleration method to improve clarity.
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Checklist
pytest tests -m slow --runslow) have passed locallyCurrent behavior
Currently, the Flight class calculates various kinematic properties, but it does not explicitly expose the axial acceleration (acceleration along the rocket's longitudinal axis) as a direct property or method. Users have to calculate it manually from other components.
New behavior
This PR adds the calculation of the axial acceleration to the Flight class:
Breaking change